Draft
Conversation
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidgamero The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
cncf-cla: no
davidgamero
force-pushed
the
pin-actions-to-sha
branch
from
f879ec6 to
d8a5dcb
Compare
Pin remaining mutable tag references to full commit SHAs with version comments for traceability. Add zizmor as a CI job to enforce SHA pinning and detect SHA-to-version-comment mismatches on every push and PR. Also fix missing @ separator in codeql-analysis.yml analyze action reference.
davidgamero
force-pushed
the
pin-actions-to-sha
branch
from
d8a5dcb to
8542fa3
Compare
k8s-ci-robot
added
cncf-cla: yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to follow guidance from https://github.com/kubernetes/community/blob/main/github-management/github-actions-policy.md
added zizmor lint step validating SHAs exist and match
if people would prefer to hold off on the lint step i can reduce PR scope to just the pinned SHAs, i added linting to give some way to validate the SHAs are correct
using zizmor in the meantime to lint. this will likely be applied via repo/org settings in the future and we can drop that dependency from the test workflow
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#managing-github-actions-permissions-for-your-repository