-
Notifications
You must be signed in to change notification settings - Fork 868
feat: add production-ready MNIST example for PyTorch #3063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Thanks for raising this, @Snehadas2005. I see its still a draft PR but few minor suggestions which will help you.
Happy contributing. |
|
Thank you so much, @jaiakash, for the detailed feedback and references. I really appreciate it. That makes sense. I will convert the example into a Jupyter notebook and align it with the existing example patterns you shared, focusing on clarity and readability for data scientists. I also appreciate the note on DCO signing. I will fix the commit signatures and ensure all future commits are properly signed. Thanks again for the guidance, happy to iterate further and adjust based on feedback from the team. |
* feat: kep for flux hpc (2841) This KEP proposes adding an hpcPolicy to support Flux Framework and (in the future) other workload managers that provide more traditional HPC features. Signed-off-by: vsoch <vsoch@users.noreply.github.com> * review: see updates below. Changed crd examples to reflect documentation removed tasks from definition - can go in settings removed mentions of minicluster out of context specified train image instead of custom logic added user stories Signed-off-by: vsoch <vsoch@users.noreply.github.com> * feat: flux policy Update the KEP to define a FluxMLPolicySource that exposes attributes specific to Flux. Signed-off-by: vsoch <vsoch@users.noreply.github.com> * review: add details of cm and init container Signed-off-by: vsoch <vsoch@users.noreply.github.com> --------- Signed-off-by: vsoch <vsoch@users.noreply.github.com> Co-authored-by: vsoch <vsoch@users.noreply.github.com> Signed-off-by: Sneha Das <154408198+Snehadas2005@users.noreply.github.com>
…ation Signed-off-by: Sneha Das <154408198+Snehadas2005@users.noreply.github.com>
Signed-off-by: Sneha Das <154408198+Snehadas2005@users.noreply.github.com>
Signed-off-by: Sneha Das <154408198+Snehadas2005@users.noreply.github.com>
Signed-off-by: Sneha Das <154408198+Snehadas2005@users.noreply.github.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Signed-off-by: Sneha Das <154408198+Snehadas2005@users.noreply.github.com>
Signed-off-by: Sneha Das <154408198+Snehadas2005@users.noreply.github.com>
Signed-off-by: Sneha Das <154408198+Snehadas2005@users.noreply.github.com>
Signed-off-by: Sneha Das <154408198+Snehadas2005@users.noreply.github.com>
Signed-off-by: Sneha Das <154408198+Snehadas2005@users.noreply.github.com>
What this PR does / why we need it:
This PR refactors and updates the existing PyTorch Jupyter Notebooks to fully support the Kubeflow Trainer V2 SDK. These updates transition the notebooks from legacy patterns to production-ready workflows that are compatible with the latest SDK features and cross-platform environments.
Updated Workflows:
Key Improvements:
Which issue(s) this PR fixes:
Fixes #3062
Fixes #2040
PR: #2830
Checklist: