feat: Add the manager field to the podTemplateOverride object

[kaisoz]

What this PR does / why we need it:

This PR adds a manager field to the podTemplateOverrides object, indicating who created (owns) the object. This is useful for external controllers such as Kueue to identify which entries they added. This manager field is optional and is defaulted by a mutating webhook, which sets the request username for podTemplateOverrides that don’t have a manager.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #2856

Checklist:

• Docs included if any changes are user facing

[coveralls]

Pull Request Test Coverage Report for Build 22080067239

Details

• 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.03%) to 55.998%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/runtime/framework/plugins/jobset/jobset.go	1	3	33.33%

Totals
Change from base Build 22051165353:	-0.03%
Covered Lines:	1391
Relevant Lines:	2484

---

💛 - Coveralls

[kaisoz]

cc @tenzen-y @andreyvelich @astefanutti @mimowo

I also tested this manually in kind by deploying a Trainjob with a podTemplateOverride entry in a cluster with Kueue installed. The mutating webhook added manager=kubernetes-admin to my podTemplateOverride object, and manager=system:serviceaccount:kueue-system:kueue-controller-manager (the Kueue service account) to the ones added by Kueue.

[kaisoz]

The failing test seems to be a flake (Failed executing command with error: build process: clone golangci-lint: git clone --branch v2.4.0 --single-branch --depth 1 -c advice.detachedHead=false -q https://github.com/golangci/golangci-lint.git: exit status 128) Could anyone re-run it for me? Thanks!

[astefanutti]

/retest

[kaisoz]

/retest

I thought I couldn't do this here since the repo uses GH actions... 🤦🏻

[kaisoz]

/retest

[google-oss-prow]

@kaisoz: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kaisoz]

/retest

[google-oss-prow]

@kaisoz: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[google-oss-prow]

@kaisoz: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kaisoz]

@kaisoz: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

@astefanutti prow doesn't trust me 😆 . I did run the clone line in machine and it works, I expect it to work now in CI..

[astefanutti]

/ok-to-test

/restest

[kaisoz]

/retest

[astefanutti]

@kaisoz there is an issue with CI that should be fixed after you rebase this on top of #3023.

[kaisoz]

@kaisoz there is an issue with CI that should be fixed after you rebase this on top of #3023.

great @astefanutti ! Thanks! Then I think I'll wait for #3023 to be merged and then rebase 😊

[astefanutti]

@kaisoz #3023 has been merged if you want to rebase on top.

[kaisoz]

/retest

[kaisoz]

@astefanutti all green now! PTAL whenever you have time. Thanks! 🙂

[astefanutti]

@kaisoz that looks good to me overall, thanks!

I understand the webhook would automatically set the manager field to "mimic" SSA behavior, but just to be sure we don't introduce too much complexity nor "re-invent" the wheel, would having Kueue set the manager field directly in the PodTemplateOverride be working just as good?

[google-oss-prow]

@andreyvelich: GitHub didn't allow me to assign the following users: mimowo.

Note that only kubeflow members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

Thanks for the update @kaisoz!
/lgtm
/assign @mimowo @astefanutti @tenzen-y

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andreyvelich]

@kaisoz You might need to rebase this PR to fix E2Es.

[kaisoz]

@kaisoz You might need to rebase this PR to fix E2Es.

done!

[andreyvelich]

/lgtm

[andreyvelich]

Thanks @kaisoz!
/lgtm
/assign @astefanutti @tenzen-y

[andreyvelich]

/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [andreyvelich]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment