Skip to content

fix(operator): Prevent JobSet recreation when its TTL has expired#3013

Merged
google-oss-prow[bot] merged 1 commit intokubeflow:masterfrom
astefanutti:pr-43
Jan 13, 2026
Merged

fix(operator): Prevent JobSet recreation when its TTL has expired#3013
google-oss-prow[bot] merged 1 commit intokubeflow:masterfrom
astefanutti:pr-43

Conversation

@astefanutti
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Prevent the recreation of the JobSet when its TTL duration has expired.

Fixes #2981

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 19742327386

Details

  • 0 of 10 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 51.264%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/trainjob_controller.go 0 1 0.0%
pkg/util/trainjob/trainjob.go 0 4 0.0%
pkg/runtime/framework/plugins/jobset/jobset.go 0 5 0.0%
Totals Coverage Status
Change from base Build 19741789363: -0.2%
Covered Lines: 1237
Relevant Lines: 2413

💛 - Coveralls

@astefanutti
Copy link
Copy Markdown
Contributor Author

/assign @kubeflow/kubeflow-trainer-team

Copy link
Copy Markdown
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me, thanks @astefanutti!
/lgtm
/approve
/assign @tenzen-y in case you have any concerns.

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit 5e75133 into kubeflow:master Jan 13, 2026
30 of 31 checks passed
@google-oss-prow google-oss-prow Bot added this to the v2.2 milestone Jan 13, 2026
@astefanutti astefanutti deleted the pr-43 branch January 18, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JobSet completed but Trainer Controller keeps recreating Pods (V2.1.0)

3 participants