Sync main into vectors and fix .NET 10 build#100
Merged
Conversation
The scheduled CI build failed with 32 IDE0370 (suppression is unnecessary) errors raised by the .NET SDK 10.0.301 analyzers with warnings treated as errors. - SemanticQuantity.cs: remove null-forgiving operators on Create<TResult>(...) calls; Create returns a non-nullable TQuantity so the suppressions were never needed. - SemanticString.cs: replace null-forgiving operators in FromStringInternal with Ensure.NotNull, which is valid in both the nullable-annotated (net5.0+) and oblivious (netstandard2.x) builds where IDE0370 flagged the suppressions. https://claude.ai/code/session_01LBGrmJHgP4RpMC9dQ2Pdox
Fix IDE0370 build errors from .NET 10 SDK analyzer
Bumps ktsu.Sdk from 2.9.0 to 2.10.0 Bumps ktsu.Sdk.Android from 2.9.0 to 2.10.0 Bumps ktsu.Sdk.App from 2.9.0 to 2.10.0 Bumps ktsu.Sdk.ConsoleApp from 2.9.0 to 2.10.0 Bumps ktsu.Sdk.iOS from 2.9.0 to 2.10.0 Bumps ktsu.Sdk.Linux from 2.9.0 to 2.10.0 Bumps ktsu.Sdk.macOS from 2.9.0 to 2.10.0 Bumps ktsu.Sdk.Windows from 2.9.0 to 2.10.0 --- updated-dependencies: - dependency-name: ktsu.Sdk dependency-version: 2.10.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: ktsu - dependency-name: ktsu.Sdk.Android dependency-version: 2.10.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: ktsu - dependency-name: ktsu.Sdk.App dependency-version: 2.10.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: ktsu - dependency-name: ktsu.Sdk.ConsoleApp dependency-version: 2.10.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: ktsu - dependency-name: ktsu.Sdk.iOS dependency-version: 2.10.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: ktsu - dependency-name: ktsu.Sdk.Linux dependency-version: 2.10.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: ktsu - dependency-name: ktsu.Sdk.macOS dependency-version: 2.10.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: ktsu - dependency-name: ktsu.Sdk.Windows dependency-version: 2.10.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: ktsu ... Signed-off-by: dependabot[bot] <support@github.com>
Bump the ktsu group with 8 updates
--- updated-dependencies: - dependency-name: Polyfill dependency-version: 10.10.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bump Polyfill from 10.8.1 to 10.10.0
--- updated-dependencies: - dependency-name: Polyfill dependency-version: 10.11.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bump Polyfill from 10.10.0 to 10.11.0
# Conflicts: # Directory.Packages.props # Semantics.Strings/SemanticString.cs # Semantics.Strings/Semantics.Strings.csproj
Add explicit accessibility modifiers to IUnit/IPhysicalQuantity members (IDE0040), document UnitConversionException constructors (CS1591), remove the duplicate <typeparam> across generated and hand-written partials so the logarithmic types document T once (CS1710), and dedupe using directives in the test project introduced by the main merge (CS0105/IDE0005).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
vectorsbranch (the 2.0 rewrite) had diverged frommainby 96 ahead / 29 behind and did not build under the current .NET 10 SDK (98 errors). The missing 29 commits were largely the tooling that fixes it:ktsu.Sdk2.10.2 (vectors pinned 2.8.0), Polyfill bumps, theSystem.Text.Jsonpackage refs, and main's earlier analyzer-error fixes. This bringsvectorsup to date and green.What
origin/mainintovectors. Three conflicts, all resolved toward main's newer/fixed versions while preserving the generator-only packages vectors adds (Microsoft.Bcl.AsyncInterfaces,Microsoft.CodeAnalysis.*,ktsu.CodeBlocker):Directory.Packages.props— Polyfill 10.11.0, keep generator packages.Semantics.Strings.csproj— addSystem.Text.Jsonref (Polyfill already present).SemanticString.cs— take main'sEnsure.NotNullnullable fix.global.jsonauto-merged to SDK 2.10.2.IDE0040— explicitpubliconIUnit/IPhysicalQuantitymembers.CS1591— XML docs onUnitConversionExceptionconstructors.CS1710— removed the duplicate<typeparam name="T">from the hand-written logarithmic partials (Cents,Semitones,Decibels,Gain,DirectionalityIndex,PH) soTis documented once (the generated half keeps it).CS0105/IDE0005— deduped using directives in 8 test files that the merge duplicated.Result
dotnet build -c Release: 0 errors.Follow-ups (not in this PR)
System.Text.Json/System.IO.Pipelines10.0.9 emit "doesn't support net5.0/net6.0/net7.0" warnings viaSemantics.Strings/Semantics.Paths. Pre-existing from main; consider dropping those TFMs or settingSuppressTfmSupportBuildWarnings.