Open
Conversation
Member
|
Thanks, I'll try it out. I think this might be very useful in some of the other repositories (where there are many more non-bazel dependencies). Would also be good to add a job to the CI to test that it works. |
Contributor
Author
|
Super long build time since nix builds Bazel from scratch (the wrapper causes the hash to change triggering a rebuild). I think there might be a way around it (defining a new Bazel, opposed to modifying an old one), but this would also go away with a nix cache. The validity of the definition (nix check flake) only takes a few seconds though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I mentioned nix on discord- but this is the flake I've been using. Note the magic of nix is that you could pin nixpkgs to a release or commit and running
nix developon any computer will give, verifiably, the same environment and same binaries.Obviously no pressure to merge this in. I just think it's nice to have the option.