Open
Conversation
Member
Author
|
Added some line and commit comments |
tlyu
force-pushed
the
comment-persistence
branch
from
f49c96e to
cc19d23
Compare
Member
Author
|
OK after rebase, it looks like f49c96e (unqualified SHA hash) doesn't show the comments but tlyu/krbdev-services@f49c96e might? Weird. |
Member
There was a problem hiding this comment.
Commenting on lines on the pull-request diff (the "files changed" tab) are supposed to remain persistent even if the commits involved change. "kaduk commented on an outdated diff", etc..
tlyu
force-pushed
the
comment-persistence
branch
2 times, most recently
from
1e77638 to
1d4c099
Compare
Member
Author
|
Weird, your line comments got preserved after rebase and mine (on a different commit) didn't. |
Member
That's because I wasn't commenting on a commit -- I was commenting on the diff associated with the pull request. (The UI for finding this is rather poor.) |
tlyu
force-pushed
the
comment-persistence
branch
from
1d4c099 to
9fbf749
Compare
tlyu
force-pushed
the
comment-persistence
branch
from
9fbf749 to
4de1eba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.