Skip to content

Conversation

@Harsh-Naicker
Copy link

@Harsh-Naicker Harsh-Naicker commented May 18, 2025

  • Added support for server sent events so that they are not buffered in Krakend
  • Added testing code to validate new implementation.

Related issue: #924

… krakend (#1)

- Added support for server sent events so that they are not buffered in Krakend
- Added testing code to validate new implementation.
@alombarte
Copy link
Member

Hello @Harsh-Naicker , thank you for submitting an interesting feature to KrakenD. A few quick comments (without deeply reviewing the code). These are more form than content:

  1. The SSE feature shouldn’t live in KrakenD-CE since that repo is for dependency stacking only, it needs its own repo.
  2. Using SSE must enforce no-op output encoding programmatically, not rely on config.
  3. All tests must be in Go, not JS; currently, the test setup is out of scope for KrakenD’s core testing practices.

@Harsh-Naicker
Copy link
Author

Harsh-Naicker commented May 20, 2025

@alombarte Thank you so much for taking a brief look at my PR. Should I do the following:

  1. Wait for your detailed review on the code.
  2. Create a new repository with the SSE support code with all the comments addressed from your review.
  3. Update this PR to use the new module as a dependency.

Awaiting your kind response.

@alombarte
Copy link
Member

alombarte commented Jun 6, 2025

Hello @Harsh-Naicker,

We didn't have the time to review the code yet, but as this is an interesting feature I have created a new repo krakend-sse where you can push the code in a PR. We will try to review the code you push there during June. This PR in krakend-ce should be the integration of the external component.

@Harsh-Naicker
Copy link
Author

@alombarte
Thanks for considering this feature. I will raise a PR to the new repo soon so that the krakend team can review it.

@alombarte
Copy link
Member

Thanks @ Harsh-Naicker for looking into this.
If you're able to work on this shortly, we have resources to review it and include it on KrakenD CE 2.11 now.

@Harsh-Naicker
Copy link
Author

Thanks @ Harsh-Naicker for looking into this. If you're able to work on this shortly, we have resources to review it and include it on KrakenD CE 2.11 now.

I will try to move on this as soon as possible!

@Harsh-Naicker
Copy link
Author

Hey @alombarte , I have raised a PR on krakend-sse:

krakend/krakend-sse#1

Hoping to hear back soon!

@alombarte
Copy link
Member

Thank you for your quick reaction! The team will look into the PR shortly.

@andrebrito16
Copy link

Any updates? I really would appreciate if Krakend supports SSE.

@Harsh-Naicker
Copy link
Author

Hey @alombarte , had been inactive due to some work at my end but I have updated the krakend-sse PR after addressing the comments by @dhontecillas . Hoping for a re-review soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants