-
Notifications
You must be signed in to change notification settings - Fork 482
Added support for server sent events in Krakend Community Edition #1004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… krakend (#1) - Added support for server sent events so that they are not buffered in Krakend - Added testing code to validate new implementation.
Removed unused receivers
|
Hello @Harsh-Naicker , thank you for submitting an interesting feature to KrakenD. A few quick comments (without deeply reviewing the code). These are more form than content:
|
|
@alombarte Thank you so much for taking a brief look at my PR. Should I do the following:
Awaiting your kind response. |
|
Hello @Harsh-Naicker, We didn't have the time to review the code yet, but as this is an interesting feature I have created a new repo krakend-sse where you can push the code in a PR. We will try to review the code you push there during June. This PR in krakend-ce should be the integration of the external component. |
|
@alombarte |
|
Thanks @ Harsh-Naicker for looking into this. |
I will try to move on this as soon as possible! |
|
Hey @alombarte , I have raised a PR on krakend-sse: Hoping to hear back soon! |
|
Thank you for your quick reaction! The team will look into the PR shortly. |
|
Any updates? I really would appreciate if Krakend supports SSE. |
|
Hey @alombarte , had been inactive due to some work at my end but I have updated the |
Related issue: #924