Skip to content

update e2e expected outputs for kpt status block changes#1227

Merged
efiacor merged 2 commits intokptdev:mainfrom
Nordix:update-e2e-expected-outputs-for-kpt-status
Apr 13, 2026
Merged

update e2e expected outputs for kpt status block changes#1227
efiacor merged 2 commits intokptdev:mainfrom
Nordix:update-e2e-expected-outputs-for-kpt-status

Conversation

@aravindtga
Copy link
Copy Markdown
Contributor

Summary

Updates all e2e test expected outputs to account for kpt@main now writing status.conditions into Kptfile after fn render.

What changed

kpt now emits a status block in Kptfile after rendering (As part of kptdev/kpt#4418):

status:
 conditions:
    - type: Rendered
     status: "True"
     reason: RenderSuccess

This caused all e2e tests to fail because the expected diff.patch files didn't include this new output.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 20, 2026

Deploy Preview for krm-function-catalog canceled.

Name Link
🔨 Latest commit 9a4cf1a
🔍 Latest deploy log https://app.netlify.com/projects/krm-function-catalog/deploys/69ce972fee3bb10008b9bf15

Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
@aravindtga aravindtga force-pushed the update-e2e-expected-outputs-for-kpt-status branch from a847e97 to 1d13dcb Compare March 20, 2026 18:16
@aravindtga aravindtga marked this pull request as ready for review March 20, 2026 18:33
Copilot AI review requested due to automatic review settings March 20, 2026 18:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates golden e2e diff.patch fixtures so the test harness matches kpt@main behavior of writing status.conditions into Kptfile after render, preventing widespread e2e failures.

Changes:

  • Updated expected git diff patches to include Kptfile status.conditions output after function render.
  • Refreshed a few Kptfile serialization details in expected patches (e.g., key ordering / quoting) that change when Kptfile is rewritten.

Reviewed changes

Copilot reviewed 56 out of 56 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/starlark/non-standard-features/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
tests/starlark/map-key-inline-comment/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
tests/starlark/load-library/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
tests/starlark/empty-input/.expected/diff.patch Golden diff updated to include rendered status (including failure condition/message).
tests/set-namespace/wysiwyg-authroing-blueprint-from-basens/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
tests/set-namespace/wysiwyg-add-blueprint-resource/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
tests/set-namespace/replace-match/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
tests/set-namespace/replace-local-raw-edit/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
tests/set-namespace/replace-all/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
tests/set-namespace/no-fnconfig-resource/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
tests/set-labels/wrong-config-group/.expected/diff.patch Golden diff updated to include rendered status (failure condition/message).
tests/set-labels/wrong-config-data-type/.expected/diff.patch Golden diff updated to include rendered status (failure condition/message).
tests/set-labels/setlabels-config/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
tests/set-labels/ill-formatted-fn-config/.expected/diff.patch Golden diff updated to include rendered status (failure condition/message).
tests/set-labels/empty-resource/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
tests/set-labels/empty-list/simple/.expected/diff.patch Golden diff updated to include rendered status (failure condition/message).
tests/set-labels/empty-list/advanced/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
tests/set-labels/configmap-config/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
tests/set-image/set-image-with-same-name/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
tests/set-image/no-newName-or-newTag/.expected/diff.patch Golden diff updated to include rendered status (failure condition/message).
tests/set-image/no-image-name/.expected/diff.patch Golden diff updated to include rendered status (failure condition/message).
tests/set-annotations/local-config/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
tests/set-annotations/legacy-config/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
tests/set-annotations/empty-list/simple/.expected/diff.patch Golden diff updated to include rendered status (failure condition/message).
tests/set-annotations/empty-list/advanced/.expected/diff.patch Golden diff updated to include rendered status (failure condition/message).
tests/set-annotations/additional-annotations/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
tests/search-replace/no-results/.expected/diff.patch Golden diff updated to include rendered status; reflects Kptfile rewrite ordering/quoting.
tests/gatekeeper/valid/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
tests/gatekeeper/v1beta1-template/.expected/diff.patch Golden diff updated to include rendered status (failure condition/message).
tests/gatekeeper/dryrun/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
tests/apply-setters/no-matches-error/.expected/diff.patch Golden diff updated to include rendered status; reflects Kptfile rewrite key ordering.
examples/starlark-validation/.expected/diff.patch Golden diff updated to include rendered status (failure condition/message).
examples/starlark-set-namespace/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
examples/starlark-poddisruptionbudget/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
examples/starlark-load-library/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
examples/starlark-inject-sidecar/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
examples/set-namespace-simple/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
examples/set-namespace-kpt-package-context/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
examples/set-namespace-depends-on/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
examples/set-labels-simple/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
examples/set-labels-full-coverage/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
examples/set-image-simple/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
examples/set-image-digest/.expected/diff.patch Golden diff updated to include rendered status; reflects Kptfile rewrite key ordering.
examples/set-image-advanced/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
examples/set-enforcement-action-simple/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
examples/set-annotations-simple/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
examples/set-annotations-advanced/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
examples/search-replace-simple/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
examples/kubeconform-simple/.expected/diff.patch Golden diff updated to include rendered status; reflects Kptfile rewrite quoting.
examples/gatekeeper-warning-only/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
examples/gatekeeper-invalid-configmap/.expected/diff.patch Golden diff updated to include rendered status (failure condition/message).
examples/gatekeeper-disallow-root-user/.expected/diff.patch Golden diff updated to include rendered status (failure condition/message).
examples/create-setters-simple/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
examples/apply-setters-simple/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
examples/apply-replacements-simple/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.
contrib/examples/delete-annotations-simple/.expected/diff.patch Golden diff updated to include rendered status in Kptfile.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Collaborator

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only saw this message on test fails. Just wondering why we only see this error:

pkg.render: pkg .:
+        	pipeline.run: already handled error

@aravindtga
Copy link
Copy Markdown
Contributor Author

I only saw this message on test fails. Just wondering why we only see this error:

pkg.render: pkg .:
+        	pipeline.run: already handled error

The "already handled error" is an internal sentinel error used by the function runner - when a function fails, the actual error details are printed to CLI output, and this sentinel is returned to signal "already printed, just exit non-zero."
It was never meant to be serialized to a user-visible string, but now that we write status conditions to the Kptfile, it gets exposed.

We could iterate on this to extract the actual error and populate the condition message. However, the renderStatus field will capture the detailed information about each pipeline step, including the function image, exit code, stderr, and structured error results. So the condition message becomes somewhat redundant for diagnosing failures.
If required, we can populate this with renderStatus.errorSummary as part of the renderStatus PR kptdev/kpt#4437.

@liamfallon
Copy link
Copy Markdown
Collaborator

I only saw this message on test fails. Just wondering why we only see this error:

pkg.render: pkg .:
+        	pipeline.run: already handled error

The "already handled error" is an internal sentinel error used by the function runner - when a function fails, the actual error details are printed to CLI output, and this sentinel is returned to signal "already printed, just exit non-zero." It was never meant to be serialized to a user-visible string, but now that we write status conditions to the Kptfile, it gets exposed.

We could iterate on this to extract the actual error and populate the condition message. However, the renderStatus field will capture the detailed information about each pipeline step, including the function image, exit code, stderr, and structured error results. So the condition message becomes somewhat redundant for diagnosing failures. If required, we can populate this with renderStatus.errorSummary as part of the renderStatus PR kptdev/kpt#4437.

That's fine @aravindtga , I was just curious.

Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
@efiacor efiacor merged commit 47255bb into kptdev:main Apr 13, 2026
11 checks passed
@efiacor efiacor deleted the update-e2e-expected-outputs-for-kpt-status branch April 13, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants