Refactor set-image to use kustomize filters properly#1209
Merged
efiacor merged 3 commits intokptdev:masterfrom Jan 12, 2026
Merged
Refactor set-image to use kustomize filters properly#1209efiacor merged 3 commits intokptdev:masterfrom
efiacor merged 3 commits intokptdev:masterfrom
Conversation
mozesl-nokia
requested review from
efiacor,
kispaljr and
liamfallon
as code owners
✅ Deploy Preview for krm-function-catalog canceled.
|
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
mozesl-nokia
force-pushed
the
set-image-refact
branch
from
b94e7e0 to
917770f
Compare
liamfallon
approved these changes
Jan 10, 2026
Collaborator
liamfallon
left a comment
liamfallon
left a comment
There was a problem hiding this comment.
Nice cleanup of the function. It's also great to use the kustomize code directly and get rid of the cloned code.
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
efiacor
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes kptdev/kpt#4344
Rewrote the logic so that even with the "default" image paths we use the kustomize filter that the
additionalImageFieldsmethod uses. Thus, the vendored inthird_partyfiles are now removed.This fixes the issue where tags are appended without a
:. Also, initContainers now works in the default case.