avoid quoted string at fnresult Field unmarshal#4549
Open
tgzsolt wants to merge 1 commit into
Open
Conversation
tgzsolt
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dosubot
Bot
added
size:M
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR refines Field unmarshalling to better handle YAML scalar nodes when extracting currentValue and proposedValue, avoiding stringification overhead and improving nil-safety.
Changes:
- Renamed local variables from
rnodetorNodefor consistency withyaml.RNode. - Updated parsing for
currentValue/proposedValueto use raw scalar values where applicable, with additional nil checks. - Preserved existing trimming behavior after value extraction.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+186
to
195
| if currentValue, err := rNode.Pipe(yaml.Lookup("currentValue")); err == nil && currentValue.YNode() != nil { | ||
| switch currentValue.YNode().Kind { | ||
| case yaml.ScalarNode: | ||
| in.CurrentValue = currentValue.YNode().Value | ||
| default: | ||
| in.CurrentValue, err = currentValue.String() | ||
| if err != nil { | ||
| return fmt.Errorf("error parsing `field.currentValue`: %v", err) | ||
| } | ||
| } |
Comment on lines
+200
to
209
| if proposedValue, err := rNode.Pipe(yaml.Lookup("proposedValue")); err == nil && proposedValue.YNode() != nil { | ||
| switch proposedValue.YNode().Kind { | ||
| case yaml.ScalarNode: | ||
| in.ProposedValue = proposedValue.YNode().Value | ||
| default: | ||
| in.ProposedValue, err = proposedValue.String() | ||
| if err != nil { | ||
| return fmt.Errorf("error parsing `field.proposedValue`: %v", err) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desription
After parse fnresout Field with kyaml, Value can be scalar Node and if that happens, unmarshal will create quoted string
Motivation
Test type with roundtrip.RoundTripTestForAPIGroup even correct fuzzer is failing so serialize and deserialize do not give the same object