Align kpt version output format with porchctl#4545
Open
aravindtga wants to merge 1 commit into
Open
Conversation
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the kpt version command to display both a version string and the Git commit hash (with dirty state) obtained from Go's embedded build info, and changes the Makefile to inject a date-based development version instead of a Git short hash.
Changes:
- Replaces single-line version output with multi-line output including version and VCS commit hash/dirty flag via
runtime/debug.ReadBuildInfo. - Changes Makefile
versionldflag value fromgit rev-parse --short HEADto a date-stamped development string. - Updates copyright year range.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| run/run.go | Extends version command to print version plus VCS commit hash and dirty status from build info. |
| Makefile | Replaces GIT_COMMIT with date-based KPT_VERSION used in ldflags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates kpt version to display version information in the same two-line format as porchctl version, using debug.ReadBuildInfo() for git commit details.
It follows the same format/code as
porchctl.Before:
After:
For local builds:
AI usage disclosure