-
Notifications
You must be signed in to change notification settings - Fork 258
Update CONTRIBUTING file with PR review rules #4452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CsatariGergely
wants to merge
2
commits into
kptdev:main
Choose a base branch
from
nokia:add-ai-comments-to-contribution-guide
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -57,6 +57,14 @@ All submissions, including submissions by project members, require review. We | |||||
| use GitHub pull requests for this purpose. Consult [GitHub Help] for more | ||||||
| information on using pull requests. | ||||||
|
|
||||||
| Process for code reviews. Before requesting human review, a PR must: | ||||||
|
|
||||||
| * Must have all tests passing | ||||||
| * Must have all linting passing | ||||||
| * Must meet project code quality requirements, including passing all configured static analysis / SonarCloud quality gates and not reducing automated test coverage for the affected components | ||||||
| * Must have all automatically generated comments addressed (AI generated comments, SonarCloud comments, bot generated comments etc) | ||||||
|
||||||
| * Must have all automatically generated comments addressed (AI generated comments, SonarCloud comments, bot generated comments etc) | |
| * Must have all automatically generated comments addressed (AI generated comments, SonarCloud comments, bot generated comments, etc.) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list mixes an introductory sentence that already says “must” with bullets that also start with “Must…”. For clarity/consistency in CONTRIBUTING, consider either changing the bullets to short phrases (e.g., “All tests passing”) or converting the intro line to a heading and keeping “Must …” in bullets—avoid duplicating the modal.