Skip to content

fix: replace string match with regex for Compose version #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
i-defranca wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: replace string match with regex for Compose version #532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,13 @@ do_install () {
fi

composeVersion=$(docker compose version || true)
if [[ ! "$composeVersion" == *"Docker Compose version v2"* ]]; then
builtin echo -e "${start_error}We could not identify Composer V2 installed.${end_error}"
builtin echo -e "Please make sure you are running an updated Docker version that includes Compose V2:"
regex="Docker Compose version v?([25]|[1-9][0-9]+)\."

if [[ ! "$composeVersion" =~ $regex ]]; then
builtin echo -e "${start_error}We could not identify a valid Composer version installed.${end_error}"
builtin echo -e "Please make sure you are running an updated Docker version that includes Compose V2 or V5:"
builtin echo -e " Official Docker installation documentation: https://docs.docker.com/get-docker/"
builtin echo -e " Official Docker Compose V2 documentation: https://docs.docker.com/compose/reference/"
builtin echo -e " Official Docker Compose documentation: https://docs.docker.com/compose/reference/"
exit
fi

Expand Down
Loading