Skip to content

chore: more polish and qa feedbacks for guide toolbar v2 #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomaswhyyou merged 8 commits into from
Apr 6, 2026

more style fix

c02e600
Select commit
Loading
Failed to load commit list.
Merged

chore: more polish and qa feedbacks for guide toolbar v2 #931

more style fix
c02e600
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 2, 2026 in 0s

63.94% (+0.02%) compared to 74f8fe0

View this Pull Request on Codecov

63.94% (+0.02%) compared to 74f8fe0

Details

Codecov Report

❌ Patch coverage is 20.22472% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.94%. Comparing base (74f8fe0) to head (c02e600).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...es/guide/components/Toolbar/V2/GuideRowDetails.tsx 3.22% 30 Missing ⚠️
...c/modules/guide/components/Toolbar/V2/GuideRow.tsx 6.25% 15 Missing ⚠️
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 40.00% 15 Missing ⚠️
...uide/components/Toolbar/V2/GuideContextDetails.tsx 12.50% 7 Missing ⚠️
.../modules/guide/components/Toolbar/V2/FocusChin.tsx 25.00% 3 Missing ⚠️
.../components/Toolbar/V2/GuideAnnotatedStatusDot.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #931      +/-   ##
==========================================
+ Coverage   63.91%   63.94%   +0.02%     
==========================================
  Files         209      209              
  Lines        9949     9968      +19     
  Branches     1274     1274              
==========================================
+ Hits         6359     6374      +15     
- Misses       3565     3569       +4     
  Partials       25       25
Files with missing lines Coverage Δ
...src/modules/guide/components/Toolbar/V2/helpers.ts 95.08% <100.00%> (+0.25%) ⬆️
.../components/Toolbar/V2/GuideAnnotatedStatusDot.tsx 72.88% <50.00%> (+0.46%) ⬆️
.../modules/guide/components/Toolbar/V2/FocusChin.tsx 8.75% <25.00%> (+0.67%) ⬆️
...uide/components/Toolbar/V2/GuideContextDetails.tsx 4.79% <12.50%> (+0.56%) ⬆️
...c/modules/guide/components/Toolbar/V2/GuideRow.tsx 6.49% <6.25%> (+0.24%) ⬆️
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 9.60% <40.00%> (+2.44%) ⬆️
...es/guide/components/Toolbar/V2/GuideRowDetails.tsx 7.04% <3.22%> (-0.48%) ⬇️
View more details on Codecov