Skip to content

chore: change filter options to (all, active, eligible) in guide toolbar v2#927

Merged
thomaswhyyou merged 5 commits intomainfrom
thomas-kno-12204-toolbar-beta-qa-and-feedback-items-8
Apr 1, 2026
Merged

chore: change filter options to (all, active, eligible) in guide toolbar v2#927
thomaswhyyou merged 5 commits intomainfrom
thomas-kno-12204-toolbar-beta-qa-and-feedback-items-8

Conversation

@thomaswhyyou
Copy link
Copy Markdown
Contributor

@thomaswhyyou thomaswhyyou commented Apr 1, 2026

Description

Getting another round of live feedbacks per this slack thread discussion:

  • One key change is we are changing the guide list filter options to: All, Active, Eligible
  • Changed the toggle key binding to ctrl + .
  • Other misc style tweaks

Screenshots or videos

CleanShot 2026-04-01 at 15 33 24@2x

@linear
Copy link
Copy Markdown

linear bot commented Apr 1, 2026

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview, Comment Apr 1, 2026 7:32pm
javascript-nextjs-example Ready Ready Preview, Comment Apr 1, 2026 7:32pm
javascript-slack-connect-example Ready Ready Preview, Comment Apr 1, 2026 7:32pm
javascript-slack-kit-example Ready Ready Preview, Comment Apr 1, 2026 7:32pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 1, 2026

🦋 Changeset detected

Latest commit: 1add457

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@knocklabs/react Patch
guide-example Patch
ms-teams-connect-example Patch
nextjs-app-dir-example Patch
nextjs-example Patch
slack-connect-example Patch
slack-kit-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@thomaswhyyou thomaswhyyou changed the title change filter options to: all, active, eligible chore: change filter options to (all, active, eligible) in guide toolbar v2 Apr 1, 2026
@thomaswhyyou
Copy link
Copy Markdown
Contributor Author

@cursor review

weight="medium"
color="gray"
borderBottom="px"
borderStyle="dashed"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dashed underline to indicate a tooltip.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

@thomaswhyyou thomaswhyyou marked this pull request as ready for review April 1, 2026 19:39
@thomaswhyyou thomaswhyyou requested review from a team, MikeCarbone, andy-knock, cjbell, connorlindsey and meryldakin and removed request for a team April 1, 2026 19:39
@thomaswhyyou thomaswhyyou merged commit e060fcb into main Apr 1, 2026
12 of 13 checks passed
@thomaswhyyou thomaswhyyou deleted the thomas-kno-12204-toolbar-beta-qa-and-feedback-items-8 branch April 1, 2026 20:05
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 9.52381% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.63%. Comparing base (6931347) to head (1add457).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...uide/components/Toolbar/V2/GuideContextDetails.tsx 0.00% 20 Missing ⚠️
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 5.26% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #927      +/-   ##
==========================================
+ Coverage   63.48%   63.63%   +0.14%     
==========================================
  Files         208      208              
  Lines        9915     9891      -24     
  Branches     1254     1254              
==========================================
- Hits         6295     6294       -1     
+ Misses       3599     3572      -27     
- Partials       21       25       +4     
Files with missing lines Coverage Δ
...src/modules/guide/components/Toolbar/V2/helpers.ts 94.82% <ø> (ø)
...omponents/Toolbar/V2/useInspectGuideClientStore.ts 98.28% <100.00%> (+0.01%) ⬆️
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 7.16% <5.26%> (-0.05%) ⬇️
...uide/components/Toolbar/V2/GuideContextDetails.tsx 4.22% <0.00%> (-0.13%) ⬇️

... and 11 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants