Skip to content

chore: change filter options to All|Active|Eligible in guides toolbar v2 #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thomaswhyyou wants to merge 4 commits into from

cursor review feedback

c98ae33
Select commit
Loading
Failed to load commit list.
Closed

chore: change filter options to All|Active|Eligible in guides toolbar v2 #925

cursor review feedback
c98ae33
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 1, 2026 in 1s

63.46% (-0.21%) compared to 91adc51

View this Pull Request on Codecov

63.46% (-0.21%) compared to 91adc51

Details

Codecov Report

❌ Patch coverage is 7.27273% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.46%. Comparing base (91adc51) to head (c98ae33).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 0.00% 31 Missing ⚠️
...uide/components/Toolbar/V2/GuideContextDetails.tsx 4.76% 20 Missing ⚠️
Additional details and impacted files 
@@                                    Coverage Diff                                    @@
##           thomas-kno-12204-toolbar-beta-qa-and-feedback-items-6     #925      +/-   ##
=========================================================================================
- Coverage                                                  63.66%   63.46%   -0.21%     
=========================================================================================
  Files                                                        208      208              
  Lines                                                       9882     9918      +36     
  Branches                                                    1254     1254              
=========================================================================================
+ Hits                                                        6291     6294       +3     
- Misses                                                      3566     3599      +33     
  Partials                                                      25       25
Files with missing lines Coverage Δ
...omponents/Toolbar/V2/useInspectGuideClientStore.ts 98.28% <100.00%> (+0.01%) ⬆️
...uide/components/Toolbar/V2/GuideContextDetails.tsx 3.79% <4.76%> (-0.56%) ⬇️
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 6.92% <0.00%> (-0.29%) ⬇️
View more details on Codecov