⚡ Bolt: [avoid generator overhead in VectorSet.by_name]

[bashandbone]

💡 What: Replaced the generator expression inside next() with a standard for loop in VectorSet.by_name.
🎯 Why: To eliminate the overhead of creating a generator object for a simple key lookup in a dictionary's values.
📊 Impact: Provides a micro-optimization by avoiding generator creation overhead in lookups, slightly speeding up searches in hot paths.
🔬 Measurement: Review execution time in high-throughput by_name lookups or benchmark iterations compared to previous next() with generator expression overhead.

---

PR created automatically by Jules for task 16372396815061258189 started by @bashandbone

Summary by Sourcery

Enhancements:

• Improve VectorSet.by_name performance by avoiding generator creation overhead during vector lookups.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Replaces the generator-based implementation of VectorSet.by_name with an explicit for-loop to avoid generator creation overhead on lookups, providing a small performance optimization in hot paths.

File-Level Changes

Change	Details	Files
Optimize VectorSet.by_name by replacing next()+generator expression with an explicit loop to avoid generator allocation overhead.	Remove use of next() with a generator expression for matching VectorConfig instances by name. Introduce an explicit for-loop over self.vectors.values() that returns the first VectorConfig whose name matches the requested name. Return None explicitly if no matching VectorConfig is found after iterating all values. Add a brief inline comment documenting that this is a Bolt optimization to avoid generator overhead.	src/codeweaver/providers/types/vectors.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[github-actions]

🤖 Hi @bashandbone, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

[github-actions]

🤖 I'm sorry @bashandbone, but I was unable to process your request. Please see the logs for more details.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider simplifying or removing the inline # Bolt Optimization comment—either make it a neutral explanation of the approach (e.g., # Use a simple loop to avoid generator creation in hot paths) or rely on the git history/PR for the rationale to keep the codebase style consistent.
• If by_name is a known hotspot, it might be worth checking for similar next(... for ...) patterns elsewhere in this module so lookup behavior and style remain consistent and the same micro-optimization is applied where it matters.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider simplifying or removing the inline `# Bolt Optimization` comment—either make it a neutral explanation of the approach (e.g., `# Use a simple loop to avoid generator creation in hot paths`) or rely on the git history/PR for the rationale to keep the codebase style consistent.
- If `by_name` is a known hotspot, it might be worth checking for similar `next(... for ...)` patterns elsewhere in this module so lookup behavior and style remain consistent and the same micro-optimization is applied where it matters.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}