Skip to content

AP-25628: add checkpoint/restore (CRaC support in executor) #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bernd-wiswedel wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AP-25628: add checkpoint/restore (CRaC support in executor) #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions org.knime.python3/src/main/java/org/knime/python3/PythonGatewayTracker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@
import java.util.Map;
import java.util.Set;

import org.knime.core.checkpoint.PhasedInit;
import org.knime.core.checkpoint.PhasedInitSupport;
import org.knime.core.node.NodeLogger;
import org.knime.python3.PythonGatewayCreationGate.PythonGatewayCreationGateListener;

Expand All @@ -79,6 +81,17 @@ public final class PythonGatewayTracker implements PythonGatewayCreationGateList

private PythonGatewayTracker() {
m_openGateways = gatewaySet();
// Support CRaC (Coordinated Restore at Checkpoint) and close all connections prior checkpointing
PhasedInitSupport.registerOrActivate(new PhasedInit<RuntimeException>() {
@Override
public void beforeCheckpoint() throws RuntimeException {
try {
clear();
} catch (IOException ex) {
LOGGER.warn("Error when forcefully terminating Python processes during phased initialization", ex);
}
Comment on lines +84 to +92
}
});
Comment on lines +85 to +94
}

/**
Expand Down
Loading