AP-25516: Derive log handler from Handler instead of StreamHandler to… #43
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a logging shutdown issue where KnimeLogHandler inheriting from StreamHandler caused problems during extension loading when logging.shutdown() is called.
Changes:
- Changed
KnimeLogHandlerbase class fromlogging.StreamHandlertologging.Handler - Removed the
selfargument from thesuper().__init__()call
marc-lehner
approved these changes
Jan 13, 2026
Contributor
|
@chaubold looks fine to me. The branch does not contain the ticket number, but I guess that does not matter here |
… allow reconfiguring it The real issue is that KnimeLogHandler inherits from StreamHandler, which by default sets self.stream = sys.stderr. When logging.shutdown() is called during extension loading, it might be triggering a cascade where flushing stderr somehow loops back. The solution is to inherit from logging.Handler directly instead of StreamHandler, since we're not actually using a stream
chaubold
force-pushed
the
enh/fix-log-handler-recursion
branch
from
ba50981 to
e6af2db
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… allow reconfiguring it
The real issue is that KnimeLogHandler inherits from StreamHandler, which by default sets self.stream = sys.stderr. When logging.shutdown() is called during extension loading, it might be triggering a cascade where flushing stderr somehow loops back. The solution is to inherit from logging.Handler directly instead of StreamHandler, since we're not actually using a stream