implement anchored psychoacoustic parameter interpolation#88
Closed
nschimme wants to merge 2 commits intoknik0:masterfrom
Closed
implement anchored psychoacoustic parameter interpolation#88nschimme wants to merge 2 commits intoknik0:masterfrom
nschimme wants to merge 2 commits intoknik0:masterfrom
Conversation
Refactor static constants into a dynamic model that scales between 16kbps and 128kbps anchors. This improves transparency and high-frequency response across the bitrate spectrum yielding a signficant average MOS delta of 0.475. Summary of changes: - Interpolate NF, POWM, and Freq Penalty based on target bitrate. - Lowered transient threshold to 2.5 to prioritize pre-echo reduction. - Hoisted quality scaling and group-size divisions out of loops. - Centralized detailed parameter tuning documentation in frame.c. - Applied sibilance protection via high-frequency masking penalties.
Contributor
Author
|
@fabiangreffrath some regressions are unavoidable because we're changing the psychoacoustic model, here the gains drastically outweigh the negatives and we see a lot of wins at lower bitrates. |
Contributor
Author
|
Having second thoughts about this implementation, I'm going to see if I can follow a more standard methodology |
Collaborator
Yes, please. Although the code changes appear logical, it seems that some of the numerical values are purely based on "gut feelings". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor static constants into a dynamic model that scales between 16kbps and 128kbps anchors. This improves transparency and high-frequency response across the bitrate spectrum yielding a signficant average MOS delta of 0.475.
Summary of changes:
See benchmark results at: https://github.com/nschimme/faac/actions/runs/23403734812