Skip to content

Conversation

@knightedcodemonkey
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings January 25, 2026 19:23
@codecov
Copy link

codecov bot commented Jan 25, 2026

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.58%. Comparing base (91e0c91) to head (d6bd8a9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/css/src/generateTypes.ts 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   90.56%   90.58%   +0.01%     
==========================================
  Files          17       17              
  Lines        6330     6342      +12     
  Branches     1147     1152       +5     
==========================================
+ Hits         5733     5745      +12     
  Misses        560      560              
  Partials       37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where importing vanilla-extract files (.css.ts, .css.js, etc.) didn't trigger declaration mode sidecar generation. The core fix updates the hasStyleImports function in generateTypes.ts to recognize vanilla-extract files as style resources.

Changes:

  • Added isVanillaExtractResource helper to detect vanilla-extract files and integrated it into the hasStyleImports function
  • Added comprehensive test fixtures for vanilla-extract in the Playwright mode demo (card component, host element, tests)
  • Fixed Windows symlink compatibility in tests by using 'junction' type
  • Updated documentation to mention vanilla-extract files in style resource listings
  • Bumped @knighted/css package version from 1.2.0-rc.0 to 1.2.0-rc.1

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/css/src/generateTypes.ts Added isVanillaExtractResource function and integrated it into hasStyleImports to detect vanilla-extract files
packages/css/test/generateTypes.test.ts Added test for vanilla-extract detection and fixed Windows symlink compatibility
packages/playwright/src/mode/declaration/vanilla-card.css.ts New vanilla-extract styles for the test card component
packages/playwright/src/mode/declaration/vanilla-card.tsx New React component using vanilla-extract styles
packages/playwright/src/mode/declaration/vanilla-host.ts New Lit element host for testing vanilla-extract in Shadow DOM
packages/playwright/src/mode/index.ts Integration of vanilla-extract card into mode demo
packages/playwright/src/mode/constants.ts Added test ID constants for vanilla-extract components
packages/playwright/test/mode.spec.ts Added Playwright test for vanilla-extract light/shadow DOM style matching
packages/playwright/rspack.mode.config.js Added loader configuration for .css.ts files
packages/playwright/package.json Bumped @knighted/css dependency to 1.2.0-rc.1
packages/css/package.json Bumped package version to 1.2.0-rc.1
package-lock.json Updated lock file with new version
docs/type-generation.md Updated documentation to mention vanilla-extract files
docs/plugin.md Added clarification about &combined usage
docs/loader.md Added comparison table between loader and loader-bridge

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey knightedcodemonkey merged commit 1c0d075 into main Jan 25, 2026
12 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch January 25, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants