Skip to content

Conversation

@knightedcodemonkey
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings January 24, 2026 19:17
@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.16%. Comparing base (5612b2e) to head (593d74a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/css/src/loaderBridge.ts 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   91.23%   91.16%   -0.08%     
==========================================
  Files          16       16              
  Lines        5136     5140       +4     
  Branches      920      923       +3     
==========================================
  Hits         4686     4686              
- Misses        418      421       +3     
- Partials       32       33       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes an issue where runtime selectors in --hashed mode could incorrectly include non-class-name properties from CSS module exports, such as the default export containing CSS strings or source maps.

Changes:

  • Modified resolveCssModules to filter out default and __esModule properties when extracting CSS module class name mappings
  • Removed fallback to raw module object when resolution fails, ensuring only properly resolved locals are exported
  • Added comprehensive test coverage for the new filtering behavior
  • Updated documentation to clarify the difference between generated sidecar types and runtime selector maps

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/css/src/loaderBridge.ts Updated resolveCssModules to filter default and __esModule properties, and removed fallback to raw module in generated code
packages/css/test/loaderBridge.test.ts Added tests verifying default exports are ignored and omitted from named exports
packages/css/package.json Bumped version from 1.1.0 to 1.1.1
packages/playwright/package.json Updated dependency to @knighted/css 1.1.1
package-lock.json Updated lockfile to reflect version changes
packages/css/README.md Added note explaining that runtime selectors only include exported locals
docs/type-generation.md Added note clarifying difference between generated sidecar and runtime selectors

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey knightedcodemonkey merged commit dcfde6e into main Jan 24, 2026
12 checks passed
@knightedcodemonkey knightedcodemonkey deleted the fix/sm branch January 24, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants