Skip to content

cleanup: remove container-engine flag from the delete config - #3987

Open
nXtCyberNet wants to merge 1 commit into
knative:mainfrom
nXtCyberNet:issue/cp
Open

cleanup: remove container-engine flag from the delete config#3987
nXtCyberNet wants to merge 1 commit into
knative:mainfrom
nXtCyberNet:issue/cp

Conversation

@nXtCyberNet

Copy link
Copy Markdown

Changes

  • remove the container-engine flag from cmd/cluster.go ,
  • modified user template
  • modified documation

/kind cleanup

Fixes #3979

Release Note


Docs


Signed-off-by: nXtCyberNet <rohantech2005@gmail.com>
@knative-prow knative-prow Bot added the kind/cleanup Cleanup label Aug 3, 2026
@knative-prow
knative-prow Bot requested review from dsimansk and jrangelramos August 3, 2026 13:02
@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 3, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: nXtCyberNet / name: nXtCyberNet (4166079)

@knative-prow

knative-prow Bot commented Aug 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nXtCyberNet
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow

knative-prow Bot commented Aug 3, 2026

Copy link
Copy Markdown

Welcome @nXtCyberNet! It looks like this is your first PR to knative/func 🎉

@knative-prow knative-prow Bot added size/S 🤖 PR changes 10-29 lines, ignoring generated files. needs-ok-to-test 🤖 Needs an org member to approve testing labels Aug 3, 2026
@knative-prow

knative-prow Bot commented Aug 3, 2026

Copy link
Copy Markdown

Hi @nXtCyberNet. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nXtCyberNet nXtCyberNet changed the title cleanup: remove container-engine flag from the delete config @nXtCyberNet cleanup: remove container-engine flag from the delete config Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Cleanup needs-ok-to-test 🤖 Needs an org member to approve testing size/S 🤖 PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cluster delete: remove dead --container-engine flag

1 participant