[release-1.23] cluster: migrate registry from host container to in-cluster deployment - #3984
Open
gauron99 wants to merge 2 commits into
Open
[release-1.23] cluster: migrate registry from host container to in-cluster deployment #3984gauron99 wants to merge 2 commits into
gauron99 wants to merge 2 commits into
Conversation
Migrates func cluster create to an in-cluster registry (Deployment + Service + Contour Ingress + local-registry-hosting), matching hack/cluster.sh (knative#3718). Host trust uses registry.localtest.me; containerd mirrors hostPort :5000. Also: - Typed k8s objects for registry manifests (sigs.k8s.io/yaml) - Wait for registry HTTP readiness on 127.0.0.1:5000/v2/ - Delete help + empty-list cleanup (fold #63 CLI path; no host-container teardown) - Promote sigs.k8s.io/yaml to a direct require Rebased onto current main (resolves merge conflict). Functions#43 / knative#3856
C1: restore main's dependency floor (knative#3978); only intentional go.mod delta is promoting sigs.k8s.io/yaml to a direct require (typed registry manifests). S1: remove waitForRegistryHTTP on 127.0.0.1:5000 — Kind does not map host port 5000 (hostPort is node-local for containerd). Rely on kubectl wait --for=condition=Available like hack/cluster.sh. Functions#43 / knative#3856
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
approved
knative-prow
Bot
added
the
size/L
gauron99
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.