fix(k8s): prevent goroutine leak and deadlock in pod watcher

[vishwas-droid]

Changes

• 🐛 Fixed a critical goroutine leak inside runWithVolumeMounted by making the pod watcher loop context-aware (<-localCtx.Done()).
• 🐛 Prevented potential deadlocks/infinite hangs by introducing an errCh to handle abrupt or unexpected watch channel closures from the Kubernetes API server.
• 🧹 Cleaned up a double type assertion on event.Object to eliminate any sudden runtime panic risks when unexpected object states are encountered.

/kind bug

Release Note

Fixed a potential goroutine leak and deadlock scenario in the Kubernetes pod watcher inside `pkg/k8s`.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: vishwas-droid / name: Vishwas (4e9c6e2, 69c239b, cf8faa9, e436e70)
• ✅ login: vishwas-droid / name: vishwas-droid (b8afd6e)

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vishwas-droid
Once this PR has been reviewed and has the lgtm label, please assign gauron99 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow]

Welcome @vishwas-droid! It looks like this is your first PR to knative/func 🎉

[knative-prow]

Hi @vishwas-droid. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Copilot]

Pull request overview

This PR updates the Kubernetes pod watcher logic in pkg/k8s to avoid goroutine leaks and hangs while waiting for a pod’s container termination state during runWithVolumeMounted.

Changes:

• Made the watcher goroutine context-aware so it can exit promptly on cancellation.
• Added an error channel to surface unexpected watch channel closure from the API server.
• Removed a redundant/dangerous double type assertion on event.Object to reduce panic risk.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[matejvasek]

/ok-to-test

[vishwas-droid]

@matejvasek Addressed the Copilot suggestion. PTAL.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

[matejvasek]

Please rebase on the main branch to fix the CI issues.

[vishwas-droid]

Done, rebased on main. Can you please rerun the ci?

[codecov]

Codecov Report

❌ Patch coverage is 40.62500% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.88%. Comparing base (081d663) to head (69c239b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/k8s/persistent_volumes.go	40.62%	17 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3883      +/-   ##
==========================================
+ Coverage   53.78%   53.88%   +0.10%     
==========================================
  Files         200      200              
  Lines       23652    23674      +22     
==========================================
+ Hits        12721    12757      +36     
+ Misses       9707     9683      -24     
- Partials     1224     1234      +10     

Flag	Coverage Δ
e2e	33.46% <40.62%> (-0.01%)	⬇️
e2e go	29.40% <50.00%> (+<0.01%)	⬆️
e2e node	25.73% <50.00%> (+<0.01%)	⬆️
e2e python	29.73% <50.00%> (?)
e2e quarkus	25.85% <50.00%> (?)
e2e rust	25.32% <50.00%> (+0.06%)	⬆️
e2e springboot	23.99% <50.00%> (-0.02%)	⬇️
e2e typescript	25.84% <50.00%> (+<0.01%)	⬆️
e2e-config-ci	26.93% <0.00%> (-0.03%)	⬇️
integration	15.68% <50.00%> (+0.02%)	⬆️
unit macos-14	42.80% <0.00%> (-0.04%)	⬇️
unit macos-latest	42.80% <0.00%> (-0.04%)	⬇️
unit ubuntu-24.04-arm	43.12% <0.00%> (-0.05%)	⬇️
unit ubuntu-latest	43.66% <0.00%> (-0.04%)	⬇️
unit windows-latest	42.87% <0.00%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[matejvasek]

@vishwas-droid it appears that test related to your change has failed. Also have you addressed all the copilot's concerns?

[vishwas-droid]

@matejvasek Addressed the Copilot feedback, and the CI failure related to this PR has also been resolved.

[matejvasek]

/retest

[matejvasek]

You need to sign CLA.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

[vishwas-droid]

CLA signed, thanks.