[WIP] [DNM] kubeconfig decouple - maximum destruction#3841
Draft
gauron99 wants to merge 6 commits into
Draft
Conversation
|
Skipping CI for Draft Pull Request. |
knative-prow
Bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
approved
gauron99
force-pushed
the
push-qnslkroyspnr
branch
from
2aee563 to
94a4752
Compare
gauron99
changed the title
gauron99
force-pushed
the
push-qnslkroyspnr
branch
from
94a4752 to
672471b
Compare
gauron99
force-pushed
the
push-qnslkroyspnr
branch
from
672471b to
f74082e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3841 +/- ##
==========================================
- Coverage 53.90% 53.22% -0.68%
==========================================
Files 200 200
Lines 23652 23937 +285
==========================================
- Hits 12749 12740 -9
- Misses 9669 9969 +300
+ Partials 1234 1228 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gauron99
force-pushed
the
push-qnslkroyspnr
branch
from
f74082e to
46ff7e2
Compare
knative-prow-robot
added
the
needs-rebase
gauron99
force-pushed
the
push-qnslkroyspnr
branch
from
46ff7e2 to
07b6cf0
Compare
knative-prow-robot
removed
the
needs-rebase
gauron99
force-pushed
the
push-qnslkroyspnr
branch
9 times, most recently
from
208df13 to
176bb58
Compare
cmd/deploy_test.go (+ testdata global config.yaml): - TestDeploy_ClusterAuthPriorityFlow: ordered full ladder (config default -> stored local.yaml beats kubeconfig -> FUNC_CLUSTER(_TOKEN) env -> --cluster/--cluster-token flag), asserting func.yaml pin + .func/local.yaml token at each step, and that no token ever lands in func.yaml. - TestDeploy_SaveAuthGate: --save-auth / FUNC_SAVE_AUTH=false pins the cluster but caches no credentials; default caches. - TestDeploy_KubeconfigFallback_PinsAndStores: the 'old way' (active kubeconfig) still works and now pins + caches. - TestDeploy_ClusterTokenUpdatesStoredTokenPreservesCA: --cluster-token updates the stored token, preserves the stored cluster CA. Uses loopback cluster URLs so the IsOpenshift probe is refused instantly (avoids the multi-second DNS timeout an unreachable hostname incurs).
pkg/k8s/client_test.go:
- URLResolution_TrailingSlashNormalized: target with a trailing slash still matches.
- URLResolution_MultipleMatches_ErrorListsContexts: the ambiguity error names the
conflicting contexts + 'disambiguate'.
- ResolveKubeconfigAuth_NoteOn{Active,NonActive}Match: the 'Using kubeconfig context
<name>' note is printed on a single match (os.Stderr captured).
pkg/functions/function_unit_test.go:
- LocalAuth_LocalYAMLMode0600 + TightensPreexisting0644: credential file is 0600,
incl. re-tightening a pre-existing 0644 file.
- LocalAuth_NotInFuncYAML: credentials never serialize into func.yaml; the cluster URL
does.
gauron99
force-pushed
the
push-qnslkroyspnr
branch
from
176bb58 to
5823031
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.