Skip to content

[WIP] call Tracker.OnDeletedObserver on delete wherever tracker is used#9150

Open
maschmid wants to merge 1 commit into
knative:mainfrom
maschmid:maschmid-ondeletedobserver
Open

[WIP] call Tracker.OnDeletedObserver on delete wherever tracker is used#9150
maschmid wants to merge 1 commit into
knative:mainfrom
maschmid:maschmid-ondeletedobserver

Conversation

@maschmid

Copy link
Copy Markdown
Contributor

Fixes #9103 maybe

Proposed Changes

  • 🐛 remove references from tracker when resources are deleted

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

@knative-prow knative-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 10, 2026
@knative-prow

knative-prow Bot commented Jun 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maschmid
Once this PR has been reviewed and has the lgtm label, please assign matzew for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot requested review from Leo6Leo and creydr June 10, 2026 10:28
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.12%. Comparing base (a962fa5) to head (e55df2a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/sinkbinding/controller.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9150      +/-   ##
==========================================
+ Coverage   51.06%   51.12%   +0.06%     
==========================================
  Files         411      411              
  Lines       22130    22178      +48     
==========================================
+ Hits        11300    11339      +39     
- Misses       9958     9967       +9     
  Partials      872      872              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow

knative-prow Bot commented Jun 10, 2026

Copy link
Copy Markdown

@maschmid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests_eventing_main e55df2a link true /test reconciler-tests

Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removed subscriptions are still being "reconciled", as their references are not being removed from the tracker

1 participant