hack: remove redundant 'set -e' alongside 'set -o errexit'#8994
Conversation
'set -e' is an exact alias for 'set -o errexit'. Having both creates misleading code that implies they do different things. Keep only the long-form 'set -o errexit' for clarity.
knative-prow
bot
added
the
area/test-and-release
knative-prow
bot
added
size/XS
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
This PR removes redundant shell error-handling flags in Knative Eventing’s hack/ helper scripts, keeping the long-form set -o errexit while dropping the equivalent short-form set -e.
Changes:
- Remove
set -efromhack/install.sh(leavingset -o errexit). - Remove
set -efromhack/create-kind-cluster.sh(leavingset -o errexit).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
hack/install.sh |
Removes redundant set -e while retaining set -o errexit for fail-fast behavior. |
hack/create-kind-cluster.sh |
Removes redundant set -e while retaining set -o errexit for fail-fast behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitsinghsisodya, creydr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
/ok-to-test |
knative-prow
bot
added
ok-to-test
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8994 +/- ##
==========================================
+ Coverage 51.02% 51.04% +0.02%
==========================================
Files 409 409
Lines 22001 21990 -11
==========================================
Hits 11225 11225
+ Misses 9914 9903 -11
Partials 862 862 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #8993
Summary
set -efromhack/create-kind-cluster.shandhack/install.shset -eis an exact alias forset -o errexit. The long-form option is already present in both scripts; the short form is redundant.