hack: quote YAML_OUTPUT_DIR in rm command to prevent word-splitting

[Ankitsinghsisodya]

Fixes #8989

Summary

• Quote ${YAML_OUTPUT_DIR} in the rm -fr call in hack/generate-yamls.sh

Without quotes, a path containing spaces causes word-splitting and may silently delete files in the wrong location.

[knative-prow]

Hi @Ankitsinghsisodya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Copilot]

Pull request overview

Updates the YAML generation helper script to avoid shell word-splitting risks when cleaning the output directory.

Changes:

• Quote ${YAML_OUTPUT_DIR} in the rm -fr cleanup command to safely handle paths containing spaces.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[evankanderson]

/lgtm
/approve

[Ankitsinghsisodya]

@evankanderson

[evankanderson]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ankitsinghsisodya, evankanderson
Once this PR has been reviewed and has the lgtm label, please assign upodroid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• hack/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.06%. Comparing base (6df7e49) to head (a827def).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8990   +/-   ##
=======================================
  Coverage   51.05%   51.06%           
=======================================
  Files         409      409           
  Lines       21990    21990           
=======================================
+ Hits        11228    11230    +2     
+ Misses       9899     9898    -1     
+ Partials      863      862    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[knative-prow]

@Ankitsinghsisodya: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Ankitsinghsisodya]

@evankanderson it failed due to the flaky test. Can you again run the test sir.