Reabsed the p521 curve support on top of master#229
Open
Umair-Anwar wants to merge 7 commits intokmackay:masterfrom
Open
Reabsed the p521 curve support on top of master#229Umair-Anwar wants to merge 7 commits intokmackay:masterfrom
Umair-Anwar wants to merge 7 commits intokmackay:masterfrom
Conversation
- the implementation does not work for unknown reason, but gives overview of final performance of P-521 - details can be tracked here: kmackay#99 (comment)
- secp521r1 currently works only for uECC_OPTIMIZATION_LEVEL <= 2 and is around 6 times slower than secp256k1 on same optimisation level and around 12 time slower than secp256k1 on optimisation level 4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this is just merging two repos, where one is the origin and the other is forked but added support of the p521 curve. This forked was old and behind the origin/master. Now p521 support is rebased on origin master
Original base library: https://github.com/kmackay/micro-ecc
P521 Forked: https://github.com/microblink/micro-ecc/tree/microblink/master