Add options for downloading multimedia content

[vighnesh-sawant]

Fixes #1274
This PR adds an option to save image when right clicked on an image, save video when right clicked on an video and save video when right clicked on an audio.
In rest of the cases it gives you an option to save page as html.
I think this a better fix then the last one

[vighnesh-sawant]

Qt6 builds are failing, will look into it.

[vighnesh-sawant]

Tested for qt6 also.
@kelson42 can you please have a look at this.

[kelson42]

@vighnesh-sawant Thank you very much for this PR. I will test it this evening!

[Copilot]

Pull request overview

This PR refactors the context menu implementation in the web view by replacing the custom-built context menu with Qt WebEngine's standard context menu functionality, while adding appropriate icons and removing media control options.

Key Changes:

• Replaced custom back/forward actions with Qt WebEngine's standard context menu
• Added version-specific handling for Qt 5 vs Qt 6 API differences
• Set custom icons for back/forward actions and removed media control options

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The indentation style here is inconsistent with the rest of the file. In this file, preprocessor directives like #if are not indented (see lines 98, 104, 312, 317). Additionally, the code within the #if blocks uses 2-space indentation instead of the 4-space indentation used elsewhere.

Please adjust to match the file's style:

#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)
    QMenu* menu = QWebEngineView::createStandardContextMenu();
#else
    QMenu* menu = page()->createStandardContextMenu();
#endif
    page()->action(QWebEnginePage::Back)->setIcon(app->getAction(KiwixApp::HistoryBackAction)->icon());
    page()->action(QWebEnginePage::Forward)->setIcon(app->getAction(KiwixApp::HistoryForwardAction)->icon());
    if (page()->action(QWebEnginePage::ToggleMediaControls)) {
        menu->removeAction(page()->action(QWebEnginePage::ToggleMediaControls));
    }

[Copilot]

The createStandardContextMenu() functions can return nullptr if there is no context menu available. You should add a null check after creating the menu to prevent potential crashes when accessing menu in subsequent lines.

#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)
    QMenu* menu = QWebEngineView::createStandardContextMenu();
#else
    QMenu* menu = page()->createStandardContextMenu();
#endif
if (!menu) {
    menu = new QMenu(this);
}

Suggested change

	#endif
	#endif
	if (!menu) {
	menu = new QMenu(this);
	}

[Copilot]

Trailing whitespace detected. Please remove the trailing spaces at the end of this line.

Suggested change

[kelson42]

@vighnesh-sawant I have a bit of a hard time to identify what your PR changed from a user perspective. Could you please clarify this with a list of differences and a small description in the PR description?

That been said, I have already a small feedback:

• I believe the better approach for the "Save article as PDF" feature, is to move it in the top (toolbar) contextual menu
• "Save as..." should work like in a browser and save the multimedia element below the pointer
• I have a segfault crash scenario when I right click many times in a row (and also on the contextual menu)

[vighnesh-sawant]

@kelson42 I have changed the PR a lot, I think this a better option that I did not figure out then.
The changes from the user perspective are mentioned in the PR description

[kelson42]

@vighnesh-sawant Thank you for this new iteration. Here my remarks:

• Saving an image works, but one I have done it once, the item is not display anymore, see for example (actually I have achieved to save the thumbnail.webp once and then not anymore. Something is wrong here):

• The contextual menu should not allow anymore to save the article in PDF, please move this in the topbar contextual menu (I would suggest between "Random article" and "print"). I would recommend to do that first in a dedicated issue.

• Saving a video does not work for me, see

• To me it seems the code should allow to download anything via the right-click contextual menu. Here I have an .epub behind the link... and I can not save it.

[vighnesh-sawant]

1. This is fixed now ( I was testing on an article, not on the front page)
2. Save page as pdf as been kept in

Should I change it? (asking for confirmation)
The save page in the normal contextual menu saves as html.

3. Can you please point me to where this video is ( I am not able to reproduce this)
4. Fixed this, this is named as save link,if we need this to be named as something else please do tell.

[vighnesh-sawant]

@kelson42 forgot to tag you please look at this iteration!

[kelson42]

@vighnesh-sawant

Here my remarks:

• Please take the code to move the "Save article" out of the context menu in a dedicated branch. I have created a dedicated issue for that and this issue should be treated first.
• Please answer the remarks of copilat
• I see that you have code specific to Qt6... but it applies only if you have specific version 6.0.0
• You can get the TED ZIM videos from https://library.kiwix.org/#lang=&category=ted

Once #1433 implemented an merged, we should rebase this one and restest everything... sorry, but for the moment this part is still pretty fuzzy at this stage.

[rgaudin]

On the video issue, from @kelson42's screenshot, I understand it's not a <video /> at this stage, but just a poster. @kelson42 can you click the play button and retry?

[kelson42]

We are working on #1434 for the moment, once merged we will rebased and finish the work here.