ci: real-window smoke gate (Xvfb + software Vulkan)#8
Open
kingb wants to merge 1 commit into
Open
Conversation
cargo test never creates a window or GPU surface, so a winit/wgpu/X11 regression or a missing runtime dep (libxcursor1, libxkbcommon-x11-0, a monospace font) sails through CI. Add a smoke job that launches the real binary under Xvfb with mesa's lavapipe and drives it through the control socket: launch, ctl state, a typed shell round-trip, tab drag/reorder/cancel, and a stability soak — failing the build on any windowing regression, and uploading the rendered frame as an artifact. Assertions are extracted into scripts/smoke/window-smoke.sh (strict: every failure exits non-zero) and shared with the standalone container harness, refactored to delegate, so the two can't drift. Validated in an ubuntu:24.04 container against the checked-out tree. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
kingb
force-pushed
the
ci-real-window-smoke
branch
from
36b0279 to
3ae6392
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
smokeCI job that exercises the real winit+wgpu window path — the thingcargo testnever touches.The existing
checkjob runscargo test, which only exercises pure logic; it has never created a window or GPU surface. So a winit/wgpu/X11 regression, or a missing runtime dep (libxcursor1,libxkbcommon-x11-0, a monospace font — all absent fromcheck's build-only deps), sails straight through. This is the same class of gap that let a bottle ship without its launcher assets.How
smokejob (ubuntu-24.04): install build + runtime deps + Xvfb + mesa's software Vulkan (lavapipe), build the release binary, and run the assertions against a real window driven through the control socket.scripts/smoke/window-smoke.sh— strict (every failure exits non-zero, it's a gate not a report): launch,ctl state, typed shell round-trip, tab drag/reorder/cancel, stability soak, and it uploads the rendered frame as an artifact.x11-container-smoke.sh) is refactored to delegate to the same script, so the container prototype and the CI gate can't drift.Validation
Ran end-to-end in an
ubuntu:24.04container against this branch's checked-out tree — all six stages pass (launch, ctl, typed round-trip win-smoke-42, drag reorder/cancel/selection, 8s soak, no panics), frame captured. This PR's own CI run is the x86_64-runner proof.Coverage note
Directly targets the 0%-covered GPU/window files (
renderer.rs,paint.rs,headless.rs, shaders) that headless unit tests structurally can't reach.🤖 Generated with Claude Code