Add imagebox

[kimkulling]

Summary by CodeRabbit

Release Notes

• New Features

  • Added image widget support to display images within the UI framework.

• Refactor

  • Enhanced API const-correctness by updating function parameters to use const references, preventing unintended style modifications and improving code safety.

[coderabbitai]

Warning

Rate limit exceeded

@kimkulling has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 48 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3b63d5b3-163a-4faa-96a7-10c7e54a08df

📥 Commits

Reviewing files that changed from the base of the PR and between e45947a and d353e71.

📒 Files selected for processing (5)

• samples/main.cpp
• src/tinyui.cpp
• src/tinyui.h
• src/widgets.cpp
• src/widgets.h

Walkthrough

The PR introduces const-correctness improvements to function signatures and adds a new ImageBox widget type. Style parameters in Context::create and TinyUi::createContext now accept const references. A new ImageBox enum value is added to WidgetType with corresponding rendering logic in the image display path.

Changes

Cohort / File(s)	Summary
Const-correctness updates src/tinyui.h, src/tinyui.cpp	Function signatures updated to accept const Style& instead of Style& for Context::create and TinyUi::createContext, ensuring the Style parameter is not modified.
ImageBox widget type src/widgets.h, src/widgets.cpp	Added ImageBox as a new WidgetType enum value, shifting TreeView from 6 to 7. Rendering logic extended to handle ImageBox widget creation and image drawing when an image is associated.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 44.44% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'Add imagebox' accurately describes the main change: introducing a new ImageBox widget type and related functionality across the codebase.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/imagebox_feature

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

src/tinyui.h (1)

329-333: Minor formatting issue: extra leading space.

Line 329 has an extra space before CallbackI. This appears to be a cosmetic issue but deviates from consistent indentation.

Suggested fix

-     CallbackI(funcCallback callbackFunc, void *instance, size_t eventType = Events::MouseButtonDownEvent) :
+    CallbackI(funcCallback callbackFunc, void *instance, size_t eventType = Events::MouseButtonDownEvent) :

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/tinyui.h` around lines 329 - 333, Remove the stray leading space before
the constructor declaration for CallbackI so the declaration aligns with
surrounding class/struct members; locate the CallbackI(funcCallback
callbackFunc, void *instance, size_t eventType = Events::MouseButtonDownEvent)
constructor (which calls clear() and assigns mfuncCallback[eventType]) and fix
its indentation to match other member declarations.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/tinyui.h`:
- Around line 329-333: Remove the stray leading space before the constructor
declaration for CallbackI so the declaration aligns with surrounding
class/struct members; locate the CallbackI(funcCallback callbackFunc, void
*instance, size_t eventType = Events::MouseButtonDownEvent) constructor (which
calls clear() and assigns mfuncCallback[eventType]) and fix its indentation to
match other member declarations.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ab77f82f-9391-461a-84d6-793a45420da5

📥 Commits

Reviewing files that changed from the base of the PR and between f4a135d and e45947a.

📒 Files selected for processing (4)

• src/tinyui.cpp
• src/tinyui.h
• src/widgets.cpp
• src/widgets.h

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
3 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud