fix(set-version): reject unmatched package selectors

src/bin/set-version/set_version.rs

@@ -119,6 +119,23 @@ fn exec(args: VersionArgs) -> CargoResult<()> {
     let root_manifest_path = ws_metadata.workspace_root.as_std_path().join("Cargo.toml");
     let workspace_members = find_ws_members(&ws_metadata);
 
+    let mut missing = Vec::new();
+    for name in &pkgid {
+        let name = name.as_str();
+        if !workspace_members
+            .iter()
+            .any(|package| package.name.as_str() == name)
+            && !missing.contains(&name)
+        {
+            missing.push(name);
+        }
+    }
+    match missing.len() {
+        0 => {}
+        1 => anyhow::bail!("package {} doesn't exist", missing.join(", ")),
+        _ => anyhow::bail!("packages {} don't exist", missing.join(", ")),
+    }
+
     if all {
         shell_warn("The flag `--all` has been deprecated in favor of `--workspace`")?;
     }

tests/cargo-set-version/main.rs

@@ -5,6 +5,10 @@
 mod downgrade_error;
 mod dry_run;
 mod ignore_dependent;
+mod package_not_found;
+mod package_not_found_mixed;
+mod package_not_found_repeated;
+mod packages_not_found;
 mod relative_absolute_conflict;
 mod set_absolute_version;
 mod set_absolute_workspace_version;

tests/cargo-set-version/package_not_found/in/Cargo.toml

@@ -0,0 +1,9 @@
+[workspace]
+
+[package]
+name = "sample"
+version = "0.1.0"
+edition = "2015"
+
+[lib]
+path = "dummy.rs"

tests/cargo-set-version/package_not_found/mod.rs

@@ -0,0 +1,24 @@
+use cargo_test_support::Project;
+use cargo_test_support::compare::assert_ui;
+use cargo_test_support::current_dir;
+use cargo_test_support::file;
+use cargo_test_support::prelude::*;
+
+use crate::CargoCommand;
+
+#[cargo_test]
+fn case() {
+    let project = Project::from_template(current_dir!().join("in"));
+    let project_root = project.root();
+
+    snapbox::cmd::Command::cargo_ui()
+        .arg("set-version")
+        .args(["2.0.0", "--package", "missing"])
+        .current_dir(&project_root)
+        .assert()
+        .code(1)
+        .stdout_eq(file!["stdout.term.svg"])
+        .stderr_eq(file!["stderr.term.svg"]);
+
+    assert_ui().subset_matches(current_dir!().join("out"), &project_root);
+}

tests/cargo-set-version/package_not_found/out/Cargo.toml

@@ -0,0 +1,9 @@
+[workspace]
+
+[package]
+name = "sample"
+version = "0.1.0"
+edition = "2015"
+
+[lib]
+path = "dummy.rs"

tests/cargo-set-version/package_not_found_mixed/in/Cargo.toml

@@ -0,0 +1,9 @@
+[workspace]
+
+[package]
+name = "sample"
+version = "0.1.0"
+edition = "2015"
+
+[lib]
+path = "dummy.rs"

tests/cargo-set-version/package_not_found_mixed/mod.rs

@@ -0,0 +1,24 @@
+use cargo_test_support::Project;
+use cargo_test_support::compare::assert_ui;
+use cargo_test_support::current_dir;
+use cargo_test_support::file;
+use cargo_test_support::prelude::*;
+
+use crate::CargoCommand;
+
+#[cargo_test]
+fn case() {
+    let project = Project::from_template(current_dir!().join("in"));
+    let project_root = project.root();
+
+    snapbox::cmd::Command::cargo_ui()
+        .arg("set-version")
+        .args(["2.0.0", "--package", "sample", "--package", "missing"])
+        .current_dir(&project_root)
+        .assert()
+        .code(1)
+        .stdout_eq(file!["stdout.term.svg"])
+        .stderr_eq(file!["stderr.term.svg"]);
+
+    assert_ui().subset_matches(current_dir!().join("out"), &project_root);
+}

tests/cargo-set-version/package_not_found_mixed/out/Cargo.toml

@@ -0,0 +1,9 @@
+[workspace]
+
+[package]
+name = "sample"
+version = "0.1.0"
+edition = "2015"
+
+[lib]
+path = "dummy.rs"

tests/cargo-set-version/package_not_found_repeated/in/Cargo.toml

@@ -0,0 +1,9 @@
+[workspace]
+
+[package]
+name = "sample"
+version = "0.1.0"
+edition = "2015"
+
+[lib]
+path = "dummy.rs"

tests/cargo-set-version/package_not_found_repeated/mod.rs

@@ -0,0 +1,24 @@
+use cargo_test_support::Project;
+use cargo_test_support::compare::assert_ui;
+use cargo_test_support::current_dir;
+use cargo_test_support::file;
+use cargo_test_support::prelude::*;
+
+use crate::CargoCommand;
+
+#[cargo_test]
+fn case() {
+    let project = Project::from_template(current_dir!().join("in"));
+    let project_root = project.root();
+
+    snapbox::cmd::Command::cargo_ui()
+        .arg("set-version")
+        .args(["2.0.0", "-p", "missing", "-p", "missing"])
+        .current_dir(&project_root)
+        .assert()
+        .code(1)
+        .stdout_eq(file!["stdout.term.svg"])
+        .stderr_eq(file!["stderr.term.svg"]);
+
+    assert_ui().subset_matches(current_dir!().join("out"), &project_root);
+}

tests/cargo-set-version/package_not_found_repeated/out/Cargo.toml

@@ -0,0 +1,9 @@
+[workspace]
+
+[package]
+name = "sample"
+version = "0.1.0"
+edition = "2015"
+
+[lib]
+path = "dummy.rs"

tests/cargo-set-version/packages_not_found/in/Cargo.toml

@@ -0,0 +1,9 @@
+[workspace]
+
+[package]
+name = "sample"
+version = "0.1.0"
+edition = "2015"
+
+[lib]
+path = "dummy.rs"

tests/cargo-set-version/packages_not_found/mod.rs

@@ -0,0 +1,30 @@
+use cargo_test_support::Project;
+use cargo_test_support::compare::assert_ui;
+use cargo_test_support::current_dir;
+use cargo_test_support::file;
+use cargo_test_support::prelude::*;
+
+use crate::CargoCommand;
+
+#[cargo_test]
+fn case() {
+    let project = Project::from_template(current_dir!().join("in"));
+    let project_root = project.root();
+
+    snapbox::cmd::Command::cargo_ui()
+        .arg("set-version")
+        .args([
+            "2.0.0",
+            "--package",
+            "first-missing",
+            "--package",
+            "second-missing",
+        ])
+        .current_dir(&project_root)
+        .assert()
+        .code(1)
+        .stdout_eq(file!["stdout.term.svg"])
+        .stderr_eq(file!["stderr.term.svg"]);
+
+    assert_ui().subset_matches(current_dir!().join("out"), &project_root);
+}

tests/cargo-set-version/packages_not_found/out/Cargo.toml

@@ -0,0 +1,9 @@
+[workspace]
+
+[package]
+name = "sample"
+version = "0.1.0"
+edition = "2015"
+
+[lib]
+path = "dummy.rs"