Fix 633 - #645
Merged
Merged
Conversation
tungleduyxyz
commented
Jul 28, 2026
tungleduyxyz
commented
Contributor
- fix: remove columns DataTable option causing sort/search errors on Invoices and Payments #644
- List uploaded invoice translations per tenant via Kaui::AdminTenant.get_invoice_translations (uses KillBillClient::Model::Tenant.search_tenant_config with the INVOICE_TRANSLATION_ prefix, since Kill Bill has no dedicated list endpoint) - Fetch translations in AdminTenantsController#show alongside other tab data - Render a table above the upload form matching the existing Overdue/Catalog tab styling, with a View Source toggle per locale
…voices and Payments The 'columns' option defined 9 entries (7 visible + 2 hidden) but the HTML <thead> only renders visible columns (7 <th> elements). With serverSide: true, this mismatch breaks DataTables column index resolution when sorting or applying advanced search filters. Fixes #633
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.