Skip to content

use Error.isError #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisnojima wants to merge 1 commit into
base: nojima/HOTPOT-use-buffer
Choose a base branch
from
Open

use Error.isError #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions lib/log.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions src/log.iced
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@

util = require 'util'

#
# The standard logger for saying that things went wrong, or state changed,
# inside the RPC system. You can of course change this to be whatever you'd
Expand All @@ -23,7 +20,7 @@ default_level = L.INFO
stringify = (o) ->
if not o? then ""
else if o instanceof Uint8Array then new TextDecoder().decode(o)
else if util.isError(o) then o.toString()
else if Error.isError(o) then o.toString()
else ("" + o)

##=======================================================================
Expand Down
3 changes: 1 addition & 2 deletions test/all.iced
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ colors = require 'colors'
deep_equal = require 'deep-equal'
{debug,log,Logger,RobustTransport,Transport,Client} = require '../src/main'
iced = require('../src/iced').runtime
util = require 'util'

##-----------------------------------------------------------------------

Expand Down Expand Up @@ -71,7 +70,7 @@ class TestCase
logger : () -> @_global.logger()

search : (s, re, msg) ->
if util.isError(s)
if Error.isError(s)
s = s.toString()
@assert (s? and s.search(re) >= 0), msg

Expand Down