Open
Conversation
chrisnojima-zoom
force-pushed
the
nojima/ZCLIENT-slim-18
branch
from
594500d to
135d84e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 38 out of 39 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| headerStyle: {backgroundColor: Kb.Styles.globalColors.blue}, | ||
| headerTitle: () => <VerifyPhoneHeaderTitle />, | ||
| }, | ||
| headerTitle: () => <VerifyPhoneHeaderTitle phoneNumber={route.params.phoneNumber} />, |
There was a problem hiding this comment.
getOptions reads route.params.phoneNumber directly, but React Navigation route params can be undefined (and this file already treats phoneNumber as optional). Use optional chaining / a default (e.g. route.params?.phoneNumber) to avoid a runtime crash when params are missing.
Suggested change
| headerTitle: () => <VerifyPhoneHeaderTitle phoneNumber={route.params.phoneNumber} />, | |
| headerTitle: () => ( | |
| <VerifyPhoneHeaderTitle phoneNumber={route.params?.phoneNumber} /> | |
| ), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.