Skip to content

fix: clear Windows taskbar overlay icon when badge count reaches 0 #29053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omahabrad wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −5
Open

fix: clear Windows taskbar overlay icon when badge count reaches 0 #29053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions shared/desktop/app/menu-bar.desktop.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,14 @@ const MenuBar = () => {
// to be used as an overlay in the bottom right of the taskbar icon.
if (isWindows) {
const mw = getMainWindow()
const overlay =
action.payload.desktopAppBadgeCount > 0
? getAssetPath('images', 'icons', 'icon-windows-badge.png')
: null
overlay && mw?.setOverlayIcon(Electron.nativeImage.createFromPath(overlay), 'new activity')
if (action.payload.desktopAppBadgeCount > 0) {
mw?.setOverlayIcon(
Electron.nativeImage.createFromPath(getAssetPath('images', 'icons', 'icon-windows-badge.png')),
'new activity'
)
} else {
mw?.setOverlayIcon(null, '')
}
}

break
Expand Down