Draft
Conversation
tuhuynh27
requested review from
axblueblader,
duongcongtoai and
haphananhtuan
| import java.util.stream.Stream; | ||
|
|
||
| public class KqlManager { | ||
| private final Map<String, List<KevaColumnDefinition>> tableMetadata = new ConcurrentHashMap<>(); |
Collaborator
There was a problem hiding this comment.
Question: Are we going to process queries in single thread manner? If yes then we can change Map implementation to improve performance.
Ex: HashMap offer a better performance than ConcurrentHashMap in single thread
https://stackoverflow.com/questions/1378310/performance-concurrenthashmap-vs-hashmap
Member
Author
There was a problem hiding this comment.
@haphananhtuan Thanks for pointing out the issue, I've just changed to use kevaDatabase, it will be persisted along with kdb.dump
axblueblader
approved these changes
Nov 29, 2021
Member
axblueblader
left a comment
axblueblader
left a comment
There was a problem hiding this comment.
Nice work, also update docs on design decision when got time
Member
Author
|
Still cannot be merged now, the visitor class is cursed
|
tuhuynh27
force-pushed
the
master
branch
2 times, most recently
from
bb8e9d9 to
89d6dd9
Compare
tuhuynh27
force-pushed
the
develop
branch
2 times, most recently
from
fff21d9 to
87dc634
Compare
tuhuynh27
force-pushed
the
develop
branch
2 times, most recently
from
1a702d1 to
dcff9ea
Compare
tuhuynh27
force-pushed
the
develop
branch
2 times, most recently
from
5ca77a9 to
b1c70d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Naive KQL
KQL supports: