api: Remove cloudevents dependency#3150
Open
nuclearcat wants to merge 1 commit into
Open
Conversation
The cloudevents library was only used to parse the Pub/Sub event JSON envelope and read its "data" field. The envelope is a plain CloudEvents 1.0 JSON object, so parse it with json.loads() and return the parsed dict from receive_event() and pop_event() instead of a CloudEvent instance. The wire format is unchanged. This drops the cloudevents dependency, which would otherwise require Python 3.10+ and code changes with the 2.x major update. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cloudevents library was only used to parse the Pub/Sub event JSON envelope and read its "data" field. The envelope is a plain CloudEvents 1.0 JSON object, so parse it with json.loads() and return the parsed dict from receive_event() and pop_event() instead of a CloudEvent instance. The wire format is unchanged.
This drops the cloudevents dependency, which would otherwise require Python 3.10+ and code changes with the 2.x major update.