reports: limit regzbot tags and lore link to upstream trees#1987
Conversation
alanpeixinho
left a comment
alanpeixinho
left a comment
There was a problem hiding this comment.
Tested for different issues from different trees, seems ok.
|
@alanpeixinho I thought it would make sense to put stable in here. I've added it as an additional commit, since it isn't much to add. |
@alanpeixinho if you don't trust the test suite, please update it 🙏🏼 |
bhcopeland
force-pushed
the
regzbot-upstream-gating
branch
from
b49f047 to
9c32a47
Compare
knurd
left a comment
knurd
left a comment
There was a problem hiding this comment.
Don't really know this codebase, but looks fine from what I see. Just spotted two thing I wanted to mention, but they are not ciritical.
No, the added tests seems to be properly covering. |
Regression reports currently carry the #regzbot tags and a lore link to their own Message-ID regardless of the tree, but only mainline and next reports are CC'd to the regressions list. Reports for other trees (android, chromeos and so on) are out of regzbot's scope, and their lore link can point at a mail that never reached lore. Gate the regzbot tags and the lore link on the same tree check that adds the regressions list CC, through a shared is_regzbot_tree() helper, so the tags only appear on reports that regzbot will actually see and the link only appears on mails guaranteed to be archived. Reports for other trees keep the Reported-by attribution and the Signed-off-by: Ben Copeland <ben.copeland@linaro.org>
Regzbot also tracks regressions in proper stable releases, so add the stable tree to the set whose reports carry the regzbot tags, the lore link and the regressions list CC. Signed-off-by: Ben Copeland <ben.copeland@linaro.org>
bhcopeland
force-pushed
the
regzbot-upstream-gating
branch
from
9c32a47 to
0160602
Compare
5 participants
Regression reports currently carry the #regzbot tags and a lore link to their own Message-ID regardless of the tree, but only mainline and next reports are CC'd to the regressions list. Reports for other trees (android, chromeos and so on) are out of regzbot's scope, and their lore link can point at a mail that never reached lore.
Gate the regzbot tags and the lore link on the same tree check that adds the regressions list CC, through a shared is_regzbot_tree() helper, so the tags only appear on reports that regzbot will actually see and the link only appears on mails guaranteed to be archived. Reports for other trees keep the Reported-by attribution and the