fix: remove generated schema.yml file from git#1978
Conversation
This file is being removed as it can be generated from the backend code and is an unecessary burden to manually sync in git. Signed-off-by: Luiz Georg <luiz.georg@profusion.mobi>
|
shouldn't we also add it to .gitignore ? |
Signed-off-by: Luiz Georg <luiz.georg@profusion.mobi>
|
gitignored |
|
Add some lines of docs on how to create it |
We have documentation on backend/README.md |
MarceloRobert
left a comment
There was a problem hiding this comment.
I don't see much reason to remove this from the git but it's fine for me. I think that we can rephrase the readme though, it currently says "Please use it whenever the ins and outs of endpoints change." and I guess that's not going to be needed anymore.
|
Actually, I'm not sure I agree with this MR. We should be intentional of changes in the API, and commiting the schema is a good way to do that. The CI should check whether the author changed the API accidentally, by running |
|
I actually agree with you, Tales. I uploaded a new PR (#1992) that adds a check to pre-commit and CI instead |
This file is being removed as it can be generated from the backend code and is an unecessary burden to manually sync in git.