Merged
Conversation
The Leaseweb API supports a `device` parameter on the install endpoint to specify the boot device (SATA_SAS, NVME, or a disk set ID). NVMe-only servers fail with "Requested boot device SATA_SAS is not present" without this flag since the API defaults to SATA_SAS. Made-with: Cursor
There was a problem hiding this comment.
Risk assessment: Low risk.
Evidence from diff:
- Single file changed:
pkg/cmd/dedicated_servers.go - Small, scoped change (+7/-0): adds one CLI flag (
--device) and conditionally forwards it into existing install payload - No infrastructure/auth/permission/schema/shared-platform changes
- No broad refactor or cross-cutting behavior changes
Decision:
- Code review assignment not required for Low risk under policy
- Approving this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
--deviceflag tolw ds installto specify the boot device (e.g.,SATA_SAS,NVME, or a disk set ID)"Requested boot device SATA_SAS is not present"because the API defaults toSATA_SASwhen no device is specifiedUsage
Test plan
lw ds install --helpshows the new--deviceflagdevicefield supportsSATA_SAS,NVME, or disk set IDsdevice: NVMEvia direct API call to install on NVMe-only HP DL385 G11 serversMade with Cursor
Note
Low Risk
Low risk: adds an optional CLI flag that only affects
ds installrequests when explicitly provided, forwarding an extra field to the existing API call.Overview
Adds an optional
--deviceflag tolw ds installand forwards it asdevicein the/bareMetals/v2/servers/{id}/installpayload, allowing callers to choose the boot device (e.g.,SATA_SAS,NVME, or a disk set ID) instead of relying on the API default.Written by Cursor Bugbot for commit feef38a. This will update automatically on new commits. Configure here.