Add Vercel Connect OAuth conformance coverage - #155
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
reviewed — overall looks good. two suggestions to strengthen the conformance coverage: Suggestions
|
hiroTamada
approved these changes
Aug 13, 2026
Collaborator
Author
|
added both suggestions in 06faca8: the provider fixture now asserts the exact token endpoint, POST/form body, authorization-code/refresh parameters, client identity, redirect, and PKCE fields; registration now asserts response type, scope, and a non-empty client ID. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit feeb13b. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Why
Vercel Connect owns its OAuth client registration, PKCE, state, callback, and refresh behavior. Exercising its documented Custom OAuth request shape in required CI prevents OAuth server changes from remaining compatible with existing consumers while breaking this integration.
Testing
bun test(205 tests)bunx tsc --noEmit --incremental falsebun run buildwith the required OAuth client IDs and Clerk build-time configurationNote
Low Risk
Test and documentation only; no production OAuth route logic changes in the diff, so risk is limited to CI maintenance.
Overview
Adds required CI coverage for Kernel’s hosted OAuth server against the Vercel Connect Custom OAuth shape (public client, S256 PKCE, auth code + refresh).
A reusable route-level harness (
oauth-client-fixture+defineOAuthClientConformance) exercises discovery, dynamic registration, org/project authorization, code exchange, refresh rotation, and scope/org preservation on refresh. Negative cases cover bad PKCE, redirect mismatch, wrong client on refresh, and invalid public-client Basic auth without persisting token context; authorize tests assert state, redirect URI, and PKCE survive the Kernel→Clerk redirect.vercel-connect.test.tswires the Vercel contract (optionalVERCEL_CONNECT_REDIRECT_URIfor staging).docs/oauth-conformance.mddocuments the contract, local run, and live connector checks; README tells contributors to run this suite when touching OAuth discovery, registration, authorize, token, refresh, or scopes.Reviewed by Cursor Bugbot for commit 220822a. Bugbot is set up for automated code reviews on this repo. Configure here.