chore: follow up merged PR comments and flake fixes#143
Merged
sjmiller609 merged 5 commits intomainfrom Mar 10, 2026
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
There was a problem hiding this comment.
Risk assessment: Medium-High (review required, no self-approval).
Reasoning from code diff:
- Production lifecycle behavior changed across
lib/instances(create,start,restore,query) by introducing non-hydrating state derivation on hot paths, which changes when boot-marker scans/persistence happen. - Guest init sequencing changed in
lib/system/init/main.gowith conditional parallelization of network + volume setup, affecting boot-time ordering and filesystem/network interaction. - Network self-heal call semantics changed in
lib/network/allocate.go(Initialize(ctx, nil)vs empty slice), which can alter cleanup behavior depending on implementation details. - User-visible app log stream filtering changed in
lib/instances/logs.go.
Validation notes:
go test ./lib/system/init ./lib/networkpassed.go test ./lib/instancescould not run in this environment due missing embedded VM/guest-agent artifacts.
Requested reviewers: @rgarcia, @hiroTamada.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Follow-up branch from
origin/mainto address review feedback from merged PR #136 and keep flake fixes moving on a clean branch.Review-followup changes
HYPEMAN-PROGRAM-START,HYPEMAN-AGENT-READY,HYPEMAN-HEADERS-*) so user-facing app logs are cleanertoInstanceWithoutHydration), removing extra immediate log-scan/write work from the startup hot path/etc(network writes/etc/resolv.conf)StartedAtmetadata semantics as boot-epoch start preserved across standby restoreInitialize(ctx, nil)for network self-heal preserve-set clarityFlake fixes carried forward
Runningin cloud-hypervisor running-fork test pathValidation
go test -tags containers_image_openpgp ./lib/instances -run '^(TestShouldSkipAppLogLine|TestDeriveRunningState|TestHydrateBootMarkersFromLogs_RescanThrottle|TestParseBootMarkers_IgnoresStaleMarkersBeforeBootStart|TestParseBootMarkers_ReturnsLatestMarkerFromNewestLog)$'deft-kernel-dev) targeted from branch:go test -count=2 -run '^(TestForkCloudHypervisorFromRunningNetwork|TestCreateInstanceWithNetwork|TestVolumeMultiAttachReadOnly)$' -tags containers_image_openpgp -timeout=50m ./lib/instancesNote
Medium Risk
Touches instance lifecycle/state-derivation and guest init ordering; mistakes could change observed instance states/timings or break boot networking/volume mounts. Changes are localized and covered by added unit/integration test adjustments, but affect startup hot paths.
Overview
Reduces instance create/start/restore hot-path work by returning instance state via
toInstanceWithoutHydration(and newderiveStateWithoutHydration) to avoid immediate serial-log scans and metadata rewrites for boot-marker hydration.Cleans up user-facing app log streaming by filtering internal boot sentinel lines (e.g.,
HYPEMAN-PROGRAM-START,HYPEMAN-AGENT-READY,HYPEMAN-HEADERS-*) and adds tests for the filter.Hardens runtime flows: fork target-state readiness checks now treat
InitializinglikeRunning, the cloud-hypervisor running-fork test waits forRunning, guest init now parallelizes network+volume setup only when mounts don’t overlap/etc, and network self-heal callsInitialize(ctx, nil)to clearly skip orphan TAP cleanup.Written by Cursor Bugbot for commit 1646973. This will update automatically on new commits. Configure here.