Merged
Conversation
Collaborator
Author
|
minimal non-test coded added, taking liberty to merge |
There was a problem hiding this comment.
Risk assessment: Medium-High (review required, no self-approval)
Evidence from code diff (not PR description):
- Modifies shared runtime codepaths in
lib/vmm/binaries_linux.goandlib/hypervisor/firecracker/binaries.go(binary extraction/install flow, locking, atomic rename behavior). - Adds substantial new CI/test orchestration in
.github/workflows/test.yml,cmd/test-prewarm/main.go, andlib/instances/test_network_config_test.go(local registry bootstrap, subnet lease persistence, route/iptables cleanup behavior). - Large multi-file change set with behavioral effects (20 files, 1183 insertions), increasing regression surface across test/runtime setup.
Decision:
- Code review is required.
- Not approving at this stage under risk policy.
- Requested reviewers:
@rgarcia,@hiroTamada.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Medium Risk
Touches core hypervisor binary extraction paths (adds locking + atomic install) and introduces CI prewarming that depends on a local Docker registry and shared cache directories; failures here could break builds/tests or cause flaky runtime startup on first boot.
Overview
Stabilizes and speeds up CI integration tests by adding a
cmd/test-prewarmtool and wiring it into the GitHub Actions workflows to pre-mirror a small set of base images into a local registry and pre-generate system/hypervisor artifacts into a shared cache directory.Tests are updated to consume the prewarmed cache (symlinking
system/content into each tempDataDir) and to pull images viaintegrationTestImageRef()whenHYPEMAN_TEST_REGISTRYis set/strict, reducing Docker Hub rate-limit exposure.Separately hardens test infrastructure: Linux parallel test networking now allocates/leases non-conflicting subnets with cross-process locking and cleanup of stale routes/iptables artifacts, and embedded hypervisor binary extraction (
cloud-hypervisor+firecracker) is made concurrency-safe via locks and atomic temp-file renames (with a new Firecracker concurrent extraction test).Written by Cursor Bugbot for commit 7fbf752. This will update automatically on new commits. Configure here.