Skip to content

chore: stabilize testing#132

Merged
sjmiller609 merged 10 commits intomainfrom
codex/test-prewarm-local-registry
Mar 7, 2026
Merged

chore: stabilize testing#132
sjmiller609 merged 10 commits intomainfrom
codex/test-prewarm-local-registry

Conversation

@sjmiller609
Copy link
Collaborator

@sjmiller609 sjmiller609 commented Mar 7, 2026

Note

Medium Risk
Touches core hypervisor binary extraction paths (adds locking + atomic install) and introduces CI prewarming that depends on a local Docker registry and shared cache directories; failures here could break builds/tests or cause flaky runtime startup on first boot.

Overview
Stabilizes and speeds up CI integration tests by adding a cmd/test-prewarm tool and wiring it into the GitHub Actions workflows to pre-mirror a small set of base images into a local registry and pre-generate system/hypervisor artifacts into a shared cache directory.

Tests are updated to consume the prewarmed cache (symlinking system/ content into each temp DataDir) and to pull images via integrationTestImageRef() when HYPEMAN_TEST_REGISTRY is set/strict, reducing Docker Hub rate-limit exposure.

Separately hardens test infrastructure: Linux parallel test networking now allocates/leases non-conflicting subnets with cross-process locking and cleanup of stale routes/iptables artifacts, and embedded hypervisor binary extraction (cloud-hypervisor + firecracker) is made concurrency-safe via locks and atomic temp-file renames (with a new Firecracker concurrent extraction test).

Written by Cursor Bugbot for commit 7fbf752. This will update automatically on new commits. Configure here.

@sjmiller609 sjmiller609 changed the title Codex/test prewarm local registry chore: stabilize testing Mar 7, 2026
@sjmiller609 sjmiller609 marked this pull request as ready for review March 7, 2026 20:46
@sjmiller609
Copy link
Collaborator Author

minimal non-test coded added, taking liberty to merge

@sjmiller609 sjmiller609 merged commit 9a87bd5 into main Mar 7, 2026
7 checks passed
@sjmiller609 sjmiller609 deleted the codex/test-prewarm-local-registry branch March 7, 2026 20:47
@cursor cursor bot requested review from hiroTamada and rgarcia March 7, 2026 20:48
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk assessment: Medium-High (review required, no self-approval)

Evidence from code diff (not PR description):

  • Modifies shared runtime codepaths in lib/vmm/binaries_linux.go and lib/hypervisor/firecracker/binaries.go (binary extraction/install flow, locking, atomic rename behavior).
  • Adds substantial new CI/test orchestration in .github/workflows/test.yml, cmd/test-prewarm/main.go, and lib/instances/test_network_config_test.go (local registry bootstrap, subnet lease persistence, route/iptables cleanup behavior).
  • Large multi-file change set with behavioral effects (20 files, 1183 insertions), increasing regression surface across test/runtime setup.

Decision:

  • Code review is required.
  • Not approving at this stage under risk policy.
  • Requested reviewers: @rgarcia, @hiroTamada.

Open in Web View Automation 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant