Conversation
Signed-off-by: Thomas Schuetz <thomas.schuetz@dynatrace.com>
thschue
requested review from
AloisReitbauer,
christian-kreuzberger-dtx and
johannes-b
as code owners
Signed-off-by: Thomas Schuetz <thomas.schuetz@dynatrace.com>
thisthat
reviewed
Feb 10, 2023
| - An instance has to be specified on the workload and application level | ||
| - If an instance is not specified, the lifecycle toolkit will assume that there is only a single instance of the workload or application | ||
| - If an instance is not specified on the workload level, the lifecycle toolkit will lookup the corresponding application and use the instance specified there | ||
| - Properties of an instance are defined in the `KeptnApp` resource |
Member
There was a problem hiding this comment.
I would also add the propagation of this info into the span via OTel attribute
Suggested change
| - Properties of an instance are defined in the `KeptnApp` resource | |
| - Properties of an instance are defined in the `KeptnApp` resource | |
| - Properties of an instance are stored as attributes in the generated Spans |
|
|
||
| ``` | ||
|
|
||
| The `instance` property is used to specify the current instance of the application. If this property is not specified, the lifecycle toolkit will assume that there is only a single instance of the application called "single". |
Member
There was a problem hiding this comment.
Suggested change
| The `instance` property is used to specify the current instance of the application. If this property is not specified, the lifecycle toolkit will assume that there is only a single instance of the application called "single". | |
| The `instance` property is used to specify the application's current instance. If this property is not specified, the lifecycle toolkit will assume that there is only a single instance of the application called "single". |
Member
There was a problem hiding this comment.
I would suggest another name as default:
Suggested change
| The `instance` property is used to specify the current instance of the application. If this property is not specified, the lifecycle toolkit will assume that there is only a single instance of the application called "single". | |
| The `instance` property is used to specify the current instance of the application. If this property is not specified, the lifecycle toolkit will assume that there is only a single instance of the application called "main". |
Suggested change
| The `instance` property is used to specify the current instance of the application. If this property is not specified, the lifecycle toolkit will assume that there is only a single instance of the application called "single". | |
| The `instance` property is used to specify the current instance of the application. If this property is not specified, the lifecycle toolkit will assume that there is only a single instance of the application called "default". |
| spec: | ||
| instance: <name of the current instance> | ||
| [...] | ||
| instances: |
Member
There was a problem hiding this comment.
This schema would require having the same KeptnApp with the instances structure across (potentially) multiple repositories. The benefit of this proposal is that we have a complete overview of the instances' tree.
I suggest only storing the partial view in each KeptnApp, i.e., the next successors of the current instance. This way, if we want to add a successor to, let's say, production, we don't need to change the KeptnApp of dev, staging, etc.
As a drawback, this won't allow a complete overview in the KeptnApp definition and push this into the Observability platform via trace.
|
Contributor
Author
Hello and thank you for your comments!
|
|
+1 |
thisthat
reviewed
May 10, 2023
| repository: <git repository> | ||
| branch: <git branch> | ||
| path: <path to the manifest> | ||
| reposecret: <secret to access the repository> |
Member
There was a problem hiding this comment.
TC discussion: here we could use secretName and secretKey to fetch a K8s secret.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas Schuetz thomas.schuetz@dynatrace.com