Revert "fix(node-dependency-matrix): count gRPC test cases in recording calibration (0 → 2)"#102
Merged
Conversation
…ng calib…" This reverts commit e31c8a3.
There was a problem hiding this comment.
Pull request overview
Reverts PR #101 by removing the node-dependency-matrix TypeScript sample (app, fixtures, scripts, and infra manifests) from the repository, and dropping its reference from the root README.
Changes:
- Removed the
node-dependency-matrixsample application code, build configuration, and containerization assets. - Removed supporting tooling (traffic scripts, cert generation, expected-values contract) and local/Kubernetes deployment resources.
- Updated the root
README.mdto no longer listnode-dependency-matrixas an available sample.
Reviewed changes
Copilot reviewed 36 out of 41 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Removes the repository index entry for the node-dependency-matrix sample. |
| node-dependency-matrix/tsconfig.json | Removes TypeScript build configuration for the deleted sample. |
| node-dependency-matrix/src/lib/proto.ts | Removes gRPC proto-loading helper for the deleted sample. |
| node-dependency-matrix/src/lib/log.ts | Removes structured logging helper for the deleted sample. |
| node-dependency-matrix/src/lib/dependencies.ts | Removes dependency-matrix scenario runners for outbound integrations. |
| node-dependency-matrix/src/lib/config.ts | Removes environment/config loader for the deleted sample. |
| node-dependency-matrix/src/lib/asyncJobs.ts | Removes async background job implementation for the deleted sample. |
| node-dependency-matrix/src/global.d.ts | Removes global typing shim used by the deleted sample. |
| node-dependency-matrix/src/bin/tlsProxy.ts | Removes TLS proxy binary used by the deleted sample stack. |
| node-dependency-matrix/src/bin/dependencyFixture.ts | Removes fixture-service binary used by the deleted sample stack. |
| node-dependency-matrix/src/bin/app.ts | Removes the main HTTP+gRPC application for the deleted sample. |
| node-dependency-matrix/scripts/send_grpc_traffic.sh | Removes helper script for generating incoming gRPC traffic. |
| node-dependency-matrix/scripts/record_traffic.sh | Removes helper script for generating record-time HTTP traffic. |
| node-dependency-matrix/scripts/localstack-init/01-create-queue.sh | Removes LocalStack init script for the deleted sample. |
| node-dependency-matrix/scripts/generate_certs.sh | Removes certificate generation script for the deleted sample. |
| node-dependency-matrix/scripts/compose_up.sh | Removes Docker Compose startup helper script. |
| node-dependency-matrix/scripts/compose_down.sh | Removes Docker Compose teardown helper script. |
| node-dependency-matrix/README.md | Removes sample-specific documentation. |
| node-dependency-matrix/proto/dependency_matrix.proto | Removes gRPC service definitions used by the deleted sample. |
| node-dependency-matrix/package.json | Removes the sample’s Node.js package manifest and scripts. |
| node-dependency-matrix/k8s/STAGING_RUNBOOK.md | Removes staging runbook documentation for the deleted sample. |
| node-dependency-matrix/k8s/README.md | Removes Kubernetes setup documentation for the deleted sample. |
| node-dependency-matrix/k8s/port-forward.sh | Removes port-forward helper script for the deleted sample. |
| node-dependency-matrix/k8s/manifests/08-app.yaml | Removes Kubernetes app Service/Deployment manifests for the deleted sample. |
| node-dependency-matrix/k8s/manifests/07-tls-proxies.yaml | Removes Kubernetes TLS proxy manifests for the deleted sample. |
| node-dependency-matrix/k8s/manifests/06-fixture-service.yaml | Removes Kubernetes fixture-service manifests for the deleted sample. |
| node-dependency-matrix/k8s/manifests/05-redpanda.yaml | Removes Kubernetes Redpanda manifests for the deleted sample. |
| node-dependency-matrix/k8s/manifests/04-redis.yaml | Removes Kubernetes Redis manifests for the deleted sample. |
| node-dependency-matrix/k8s/manifests/03-mongo.yaml | Removes Kubernetes Mongo manifests for the deleted sample. |
| node-dependency-matrix/k8s/manifests/02-postgres.yaml | Removes Kubernetes Postgres manifests for the deleted sample. |
| node-dependency-matrix/k8s/manifests/01-mysql.yaml | Removes Kubernetes MySQL manifests for the deleted sample. |
| node-dependency-matrix/k8s/manifests/00-localstack.yaml | Removes Kubernetes LocalStack manifests for the deleted sample. |
| node-dependency-matrix/k8s/kind-config.yaml | Removes Kind cluster configuration used by the deleted sample. |
| node-dependency-matrix/k8s/deploy-kind.sh | Removes Kind deployment automation script for the deleted sample. |
| node-dependency-matrix/fixtures/expected-values.json | Removes the sample’s expectations/contract JSON used for validation. |
| node-dependency-matrix/entrypoint.sh | Removes container entrypoint script for CA bundle setup. |
| node-dependency-matrix/Dockerfile | Removes container build definition for the deleted sample. |
| node-dependency-matrix/compose.yaml | Removes Docker Compose stack definition for the deleted sample. |
| node-dependency-matrix/.gitignore | Removes sample-local ignore rules (dist, node_modules, generated artifacts). |
| node-dependency-matrix/.dockerignore | Removes Docker ignore rules for the deleted sample. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
prabaltripathiofficial
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #101