make better channel names as they result in being filenames#5
Open
usuallyarnav wants to merge 1 commit into
Open
make better channel names as they result in being filenames#5usuallyarnav wants to merge 1 commit into
usuallyarnav wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discord channel names are controlled by us and currently flow directly into memory/ name .md, so names containing path separators or ".." can escape the directory or crash the write. _safe_name whitelists and some other things ig
Please see the markdown to DB read path in "sync_markdown_files "still matches raw DB names against filenames. Since cleaining is lossy, fully reconciling that lookup is a follow-up — this PR focuses on closing the write-side path-traversal vector. Is the markdown→DB sync direction something people actually edit by hand, or is the DB the source of truth? That's for the maintainer to answer , should this be raised as an issue ?